Skip to content

Small refactor: unnecessary Array.from #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FloPinguin merged 1 commit into from
Feb 23, 2026
Merged

Small refactor: unnecessary Array.from #3279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/core/execution/PlayerExecution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,13 @@ export class PlayerExecution implements Execution {
// Record stats
this.mg.stats().goldWork(this.player, goldFromWorkers);

const alliances = Array.from(this.player.alliances());
for (const alliance of alliances) {
for (const alliance of this.player.alliances()) {
if (alliance.expiresAt() <= this.mg.ticks()) {
alliance.expire();
}
}

const embargoes = this.player.getEmbargoes();
for (const embargo of embargoes) {
for (const embargo of this.player.getEmbargoes()) {
if (
embargo.isTemporary &&
this.mg.ticks() - embargo.createdAt >
Expand Down
Loading