Small refactor/cleanup: RadialMenuElements and PlayerImpl

[VariableVince]

Description:

PR 7/x in effort to break up PR #3220. Follows on already merged #3238.

Please see if these can be merged for v30.

-RadialMenuElements:

• getAllEnabledUnits: use camelCase instead of PascalCase so change Units into units.
• getAllEnabledUnits: use StructureTypes to loop through instead of having 6 individual lines of code to check if a structure is enabled. StructureTypes contains and will keep containing the same structures as those that are checked here. PR 3220 will later on also replace the individual lines for the attack type units into a loop with a newly introduced Types array, in the same way as we do in this PR with StructureTypes.
• getAllEnabledUnits: rename the long named const addStructureIfEnabled to just addIfEnabled, which is clear enough from the context it is used in.

-PlayerImpl

• buildableUnits: removed unnecessary "as BuildableUnit" after the in-loop return; the function itself already says it returns BuildableUnit[].

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tryout33

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

Two targeted refactorings modernize the codebase: RadialMenuElements.ts replaces explicit per-type unit enabling with a generic StructureTypes-based iteration, while PlayerImpl.ts removes an unnecessary explicit type assertion, relying instead on type inference.

Changes

Cohort / File(s)	Summary
Generic Unit Enabling Refactor src/client/graphics/layers/RadialMenuElements.ts	Replaces individual type-specific unit enabling calls (City, DefensePost, Port, MissileSilo, SAMLauncher, Factory) with a single generic iteration over StructureTypes. Renames internal helper from addStructureIfEnabled to addIfEnabled. Updates imports to include StructureTypes.
Type Assertion Cleanup src/core/game/PlayerImpl.ts	Removes explicit type cast "as BuildableUnit" in buildableUnits method; returns object directly with type inference. No runtime behavior change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🎭 From many types to patterns clean,
One loop replaces what has been,
The casts now fade, the types align,
Where inference does the work just fine! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main refactoring changes across two files: RadialMenuElements and PlayerImpl, with clear focus on cleanup.
Description check	✅ Passed	The description is well-detailed and directly related to the changeset, explaining the specific refactoring goals for each file modified.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}