Small refactor: nearbyUnits readonly UnitType[]

[VariableVince]

Description:

PR 4/x in effort to break up PR #3220. Follows on already merged #3235. Precedes #3237.

Please see if these can be merged for v30.

• Game/GameImpl/GameView: nearbyUnits required "UnitType | UnitType[]" for tiles, but calls UnitGrid nearbyUnits which requires "UnitType | readonly UnitType[]". Made the requirement the same for Game/GameImpl/GameView nearbyUnits. This way, we don't have make a shallow copy of the StructureTypes array everytime we want to send it as an argument. Other callers than listNukeBreakAlliance in Util.ts are unaffected.
• Util.ts: listNukeBreakAlliance needs no shallow copy of StructureTypes anymore as argument for NearbyUnits

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tryout33

[coderabbitai]

Walkthrough

The pull request updates the nearbyUnits method signature across multiple files to accept readonly array types for the types parameter instead of mutable arrays, improving type safety. One call site is adjusted to pass the argument directly rather than spreading it.

Changes

Cohort / File(s)	Summary
nearbyUnits method signatures src/core/game/Game.ts, src/core/game/GameImpl.ts, src/core/game/GameView.ts	Updated nearbyUnits method signatures to accept UnitType | readonly UnitType[] instead of mutable arrays, tightening the type system to prefer immutable collections while preserving runtime behavior.
Call site update src/core/execution/Util.ts	Changed nearbyUnits invocation from spreading array argument to passing it directly, aligning with the updated signature.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🎯 Arrays march in single file,

Readonly and neat all the while,

No spreading, no mess—just right,

TypeScript keeps code tight! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: updating nearbyUnits to accept readonly UnitType[] arrays, which directly matches the core refactor across Game, GameImpl, and GameView.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check	✅ Passed	The pull request description clearly explains the changes: updating nearbyUnits to accept readonly arrays to align with UnitGrid's signature and avoid unnecessary shallow copies of arrays.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/core/game/Game.ts (1)

785-799: Optional: make anyUnitNearby and nearbyUnits consistent with a single-type shorthand.

anyUnitNearby (line 788) accepts only readonly UnitType[], but nearbyUnits (line 796) accepts UnitType | readonly UnitType[] — so a caller with a single UnitType must wrap it in an array for anyUnitNearby but not for nearbyUnits. This asymmetry pre-dates this PR. If you want to eliminate the inconsistency, align both to UnitType | readonly UnitType[]:

♻️ Align anyUnitNearby with nearbyUnits

  anyUnitNearby(
    tile: TileRef,
    searchRange: number,
-   types: readonly UnitType[],
+   types: UnitType | readonly UnitType[],
    predicate: (unit: Unit) => boolean,
    playerId?: PlayerID,
    includeUnderConstruction?: boolean,
  ): boolean;

The same change would propagate to GameImpl.ts, GameView.ts, and UnitGrid.ts for consistency — but that is entirely separate from this PR's scope.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/core/game/Game.ts` around lines 785 - 799, The two APIs are inconsistent:
change the anyUnitNearby signature to accept UnitType | readonly UnitType[]
(matching nearbyUnits) so callers can pass a single UnitType without wrapping;
update the declaration in Game.ts (anyUnitNearby) and then update all
implementations and overrides (e.g., GameImpl.anyUnitNearby,
GameView.anyUnitNearby, UnitGrid.anyUnitNearby) to accept the same union type,
adjust internal handling to treat a single UnitType as a one-element array where
needed, and update any call sites that assumed the old type accordingly.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/core/game/Game.ts`:
- Around line 785-799: The two APIs are inconsistent: change the anyUnitNearby
signature to accept UnitType | readonly UnitType[] (matching nearbyUnits) so
callers can pass a single UnitType without wrapping; update the declaration in
Game.ts (anyUnitNearby) and then update all implementations and overrides (e.g.,
GameImpl.anyUnitNearby, GameView.anyUnitNearby, UnitGrid.anyUnitNearby) to
accept the same union type, adjust internal handling to treat a single UnitType
as a one-element array where needed, and update any call sites that assumed the
old type accordingly.

[jrouillard]

Lgtm