Add new map: Bosphorus Straits

[TsProphet94]

Description:

Adds a new Bosphorus Map (Turkey). One of the key strategic locations in the world and control access to the Black Sea. Smaller map that most to facilitate smaller FFA and Team games. Added are a selection of nations that correspond to the location.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

TSProphet

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Adds a new "Bosphorus Straits" map: map asset and info JSON, resources manifest, map-generator registration, English localization key, Game enum entry, and playlist weight.

Changes

Cohort / File(s)	Summary
Map data & manifest map-generator/assets/maps/bosphorusstraits/info.json, resources/maps/bosphorusstraits/manifest.json	New JSON files defining the Bosphorus Straits map: map metadata, nations with coordinates and flags, scaled variants, and land tile counts. Verify coordinates, names, and tile counts.
Map generator registry map-generator/main.go	Added bosphorusstraits to the map registry. Check name consistency with resources and manifest.
Localization resources/lang/en.json	Added "bosphorusstraits": "Bosphorus Straits" to English translations. Confirm key placement and JSON punctuation to avoid syntax errors.
Game types & classification src/core/game/Game.ts	Added BosphorusStraits to GameMapType and included it in mapCategories.regional. Ensure enum string matches manifest/name.
Playlist weighting src/server/MapPlaylist.ts	Added BosphorusStraits: 3 to the server map frequency mapping. Confirm intended weight and no unintended removals.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client
    participant Playlist as MapPlaylist (Server)
    participant Game as GameMapType / MapCategories
    participant Generator as MapGenerator
    participant Resources as Map Assets / Manifest

    Client->>Playlist: request available maps
    Playlist->>Game: reference BosphorusStraits in frequency map
    Game->>Generator: include GameMapType.BosphorusStraits in regional category
    Generator->>Resources: load `resources/maps/bosphorusstraits/manifest.json` and `map-generator/assets/.../info.json`
    Resources-->>Generator: return manifest and nations data
    Generator-->>Playlist: make map available for selection
    Playlist-->>Client: return updated map list including Bosphorus Straits

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A new strait drawn on the coder's chart,
Pins of cities placed like art,
JSON sails and flags unfurled,
Bosphorus joins the game-world,
Set course — a fresh map for the heart. 🌊🗺️

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main objective of the pull request: adding a new map named Bosphorus Straits.
Description check	✅ Passed	The description is directly related to the changeset, explaining the geographic context, map purpose, and nations included in the new Bosphorus Straits map.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[TsProphet94]

cleared conflicts

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@resources/lang/en.json`:
- Around line 331-332: JSON is invalid because the "bosphorusstraits" entry is
missing a trailing comma; update the JSON by adding a comma after the
"bosphorusstraits": "Bosphorus Straits" entry so that the following
"tradersdream": "Traders Dream" entry is correctly separated (verify the keys
"bosphorusstraits" and "tradersdream" are comma-separated and the file parses).