Skip to content

Feat: Configurable Attack Ratio Increment#2864

Closed
Codimow wants to merge 2 commits intoopenfrontio:mainfrom
Codimow:main
Closed

Feat: Configurable Attack Ratio Increment#2864
Codimow wants to merge 2 commits intoopenfrontio:mainfrom
Codimow:main

Conversation

@Codimow
Copy link
Contributor

@Codimow Codimow commented Jan 11, 2026

Closes #2822

Description:

This PR adds a new setting to allow users to configure the increment step for the Attack Ratio keybinds (and scroll wheel). This addresses the need for more fine-grained control over troop deployment, especially in late-game scenarios where 10% increments can be too large.

image

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

codimo

@Codimow Codimow requested a review from a team as a code owner January 11, 2026 11:40
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Aotumuri
Copy link
Member

Aotumuri commented Jan 11, 2026

#2835
It overlaps with this.

@Codimow
Copy link
Contributor Author

Codimow commented Jan 11, 2026

@Aotumuri, oh didn't spot that, but i think my implementation is better though both accomplish the core function

@ryanbarlow97
Copy link
Contributor

I think my UI refinement PR will probably get approved first, which moves the keybinds modal into the options modal, so this may have a few issues, if you want to make a PR to merge this into "ui" branch i can approve it

@Codimow
Copy link
Contributor Author

Codimow commented Jan 12, 2026

@ryanbarlow97 sure

@iiamlewis
Copy link
Contributor

As Ryan's comments this is now out of date, please re address and open a new PR

@iiamlewis iiamlewis closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add setting to change attack ratio increment of keybind

5 participants

Comments