Feat: Configurable Attack Ratio Increment#2864
Closed
Codimow wants to merge 2 commits intoopenfrontio:mainfrom
Closed
Feat: Configurable Attack Ratio Increment#2864Codimow wants to merge 2 commits intoopenfrontio:mainfrom
Codimow wants to merge 2 commits intoopenfrontio:mainfrom
Conversation
|
|
Member
|
#2835 |
Contributor
Author
|
@Aotumuri, oh didn't spot that, but i think my implementation is better though both accomplish the core function |
Contributor
|
I think my UI refinement PR will probably get approved first, which moves the keybinds modal into the options modal, so this may have a few issues, if you want to make a PR to merge this into "ui" branch i can approve it |
Contributor
Author
|
@ryanbarlow97 sure |
Contributor
|
As Ryan's comments this is now out of date, please re address and open a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2822
Description:
This PR adds a new setting to allow users to configure the increment step for the Attack Ratio keybinds (and scroll wheel). This addresses the need for more fine-grained control over troop deployment, especially in late-game scenarios where 10% increments can be too large.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
codimo