-
Notifications
You must be signed in to change notification settings - Fork 833
[Feature] Test a skin #2857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryanbarlow97
wants to merge
319
commits into
main
Choose a base branch
from
testaskin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Feature] Test a skin #2857
Changes from all commits
Commits
Show all changes
319 commits
Select commit
Hold shift + click to select a range
1e5545f
update to team box
ryanbarlow97 e9adb6b
adds transparency when selected
ryanbarlow97 47d0135
fix input handler
ryanbarlow97 577d805
fix slider
ryanbarlow97 15799c8
update to fix, update test
ryanbarlow97 b53e476
added slider test
ryanbarlow97 f2c2f40
removed Unused @query decorator
ryanbarlow97 aa03a86
removed declaration duplicated
ryanbarlow97 4af690e
update class names to match existing definitions
ryanbarlow97 896e648
fix: check now uses correct variable
ryanbarlow97 3e631f6
added type assertion for window.showPage and fixed Duplicate default …
ryanbarlow97 9d276fd
removed unused import
ryanbarlow97 83caf85
Remove duplicate .setting-input.slider definition.
ryanbarlow97 4850971
Remove unnecessary export
ryanbarlow97 40046a7
Remove unused kingSkull variable
ryanbarlow97 9ae6bd9
Simplify the value extraction logic and improve type safety
ryanbarlow97 10f3762
removed console log
ryanbarlow97 1cd3295
Remove unused event handler methods
ryanbarlow97 7432be8
Debug logging removed
ryanbarlow97 a22eaab
Empty handler removed, Remove debug console.log, Simplify getKeyValue…
ryanbarlow97 56a619b
empty lifecycle hooks connectedCallback and disconnectedCallback have…
ryanbarlow97 b6d969a
fix locations of items
ryanbarlow97 9d66d99
ensure consistency between the local value and the event payload
ryanbarlow97 c3e283e
add reddit icon
ryanbarlow97 889462d
fix icon issue
ryanbarlow97 764f1ce
fix spacing on help modal
ryanbarlow97 b4944d5
fix text colour on slider
ryanbarlow97 42cb942
move the player list inside the modal
ryanbarlow97 0354e98
flipped image/description
ryanbarlow97 b39b58c
fix for ui
ryanbarlow97 8e6033e
username fix
ryanbarlow97 353b3b4
tighter grouping
ryanbarlow97 7cbcbd1
fix username spacing
ryanbarlow97 a611e5d
add flag selector to options
ryanbarlow97 5f34527
update flag logic based on location
ryanbarlow97 ce9a763
fix hamburger menu
ryanbarlow97 28ad955
add blur
ryanbarlow97 d3fee1f
remove shadows
ryanbarlow97 cdcbe4f
more fluid ui
ryanbarlow97 710e4c2
fixed spilling text
ryanbarlow97 2d84695
ui refinements for shadows + scrollbars
ryanbarlow97 49f0a9e
fix scrollbar
ryanbarlow97 dd29e95
(ios fix)?
ryanbarlow97 fe0e0fd
test for connection sake
ryanbarlow97 00aebed
remove race
ryanbarlow97 b451b6c
add error message
ryanbarlow97 1e0ac82
add some debugs
ryanbarlow97 d141f9a
fix a lobby kick
ryanbarlow97 830a530
remove quickplay tag
ryanbarlow97 01a0807
revert log
ryanbarlow97 824651f
Merge remote-tracking branch 'origin/main' into menu
ryanbarlow97 1f4f865
add "special"
ryanbarlow97 4f8c3dd
added an accessible label
ryanbarlow97 a81df1a
add a safe type guard for the showPage call
ryanbarlow97 590f55b
Remove empty lifecycle methods
ryanbarlow97 200bf76
Fix incorrect return value in getKeyValue
ryanbarlow97 30dd375
both interactive card containers keyboard-accessible:
ryanbarlow97 21481e1
Extract display key formatting to avoid duplication
ryanbarlow97 dd25909
Error" string should use translateText().
ryanbarlow97 8914d66
Replace inline onclick with module-based event handler
ryanbarlow97 d87c985
improve the type safety
ryanbarlow97 9c7154b
Type the window.showPage API instead of using as any
ryanbarlow97 640937a
Replaced hardcoded "Started"
ryanbarlow97 2b20af5
updated the z-index values in the JavaScript toggle logic to match th…
ryanbarlow97 afdf224
Updated the __toggleSidebar function
ryanbarlow97 4141867
fix localisations
ryanbarlow97 879e64b
some unification work into basemodal
ryanbarlow97 524d49e
fix build
ryanbarlow97 7cb818e
removed # from clan stats
ryanbarlow97 9f71a6d
unify some more and fix clantag
ryanbarlow97 d44bdd3
Merge main into menu
ryanbarlow97 0f7335e
Merge remote-tracking branch 'origin/main' into menu
ryanbarlow97 4385d15
ha ha centre a div
ryanbarlow97 ccfdca6
fill map icon
ryanbarlow97 a2b32bc
change how create/join buttons are on mobile/pc
ryanbarlow97 f9036cf
changed to just private
ryanbarlow97 be72234
added not logged in bit
ryanbarlow97 1ec3d6d
move skin button
ryanbarlow97 a2e413e
one or the other!
ryanbarlow97 10747ec
test repeating
ryanbarlow97 7d279fb
added back padding
ryanbarlow97 f057e15
flip flop logic for gold donate
ryanbarlow97 94dded3
add extra cards
ryanbarlow97 23b80ee
remove accidently debug
ryanbarlow97 13fb456
added accessibility attributes for toggle button
ryanbarlow97 e275de2
add localisation
ryanbarlow97 7b4a1e8
make showPage non-optional (removed the ?)
ryanbarlow97 b65df4e
add localisation
ryanbarlow97 1ef572e
Use showErrorModal() instead of alert()
ryanbarlow97 1a11d6d
Removed the transition-all duration-300
ryanbarlow97 f1a869e
Updated the alt text in Maps
ryanbarlow97 a35634c
removed dupe code
ryanbarlow97 16952f0
The medal tooltip on Maps now displays translated difficulty names
ryanbarlow97 01b841b
tag consistency
ryanbarlow97 f07d848
remove new items
ryanbarlow97 556e2d0
The product access in PatternButton now uses defensive checks
ryanbarlow97 bc19454
add localisation
ryanbarlow97 c592102
update comment
ryanbarlow97 8f81e28
added stats localisation
ryanbarlow97 d888111
added settings localisation
ryanbarlow97 2a92a5c
Removed the duplicate returnTo handling from firstUpdated().
ryanbarlow97 35f3ea9
Fixed the edge case. When prevValue is undefined (first time binding)…
ryanbarlow97 15bd418
add singleplayer localisation
ryanbarlow97 a223b08
added localisation
ryanbarlow97 65fb99a
add shop localisations
ryanbarlow97 4ff8f4a
Username validation
ryanbarlow97 84acbf6
Validate max timer value before enabling
ryanbarlow97 dc6c897
added a guard to the leaveLobby() method
ryanbarlow97 efb6c51
Fix UI/config mismatch
ryanbarlow97 7d0e725
adds localisaTION
ryanbarlow97 6df64e0
numeric enum reverse mapping directly instead of scanning through all…
ryanbarlow97 6c2d5b4
fixed setting keybinds as escape
ryanbarlow97 4a116da
img alt attribute now uses ${this.translation || this.mapName}
ryanbarlow97 84af95d
fix loclaisation
ryanbarlow97 4c5ed0a
add localisation
ryanbarlow97 4b00b3b
updated the Client initialisation
ryanbarlow97 e62082f
cleaner and more idiomatic TypeScript
ryanbarlow97 3cee095
The null check now uses options !== null && typeof options === "objec…
ryanbarlow97 a4a6f29
Localise the Back button
ryanbarlow97 3e1ef45
fiux map names
ryanbarlow97 3e60ecc
removed dead code
ryanbarlow97 32cc9e7
single method helper
ryanbarlow97 1faeb42
fix defaults
ryanbarlow97 112711c
streamer mode stuff
ryanbarlow97 9cd439b
fixed text
ryanbarlow97 026e4eb
ordering
ryanbarlow97 212e182
localised
ryanbarlow97 de4ff82
remvoed redundant class
ryanbarlow97 739a079
added guards using optional chaining (?.) for all the unguarded modal…
ryanbarlow97 a66b8a2
localisations
ryanbarlow97 aa175fe
added window.dispatchEvent(new CustomEvent("showPage", { detail: page…
ryanbarlow97 99ecf06
Fix shadowRoot usage
ryanbarlow97 4e81be7
ranked matchmaking
ryanbarlow97 ae2122a
matchmaking
ryanbarlow97 5b440a1
localisation
ryanbarlow97 b8904fc
change hamburger menu button
ryanbarlow97 39c00f9
accessibility attributes for keyboard and screen reader users.
ryanbarlow97 b690dd6
Remove unused translationKey attribute from <o-modal>.
ryanbarlow97 6f646a1
remove thod
ryanbarlow97 048d0bd
Added a preventHashUpdate flag
ryanbarlow97 17bb3d2
remove unneeded BR
ryanbarlow97 c32163b
Fixed the state synchronization issues
ryanbarlow97 5f098d9
removed shadow lit sutff
ryanbarlow97 6c87ca2
cleaned up hamburger menu
ryanbarlow97 748afa1
Simplified to a single cohesive code block
ryanbarlow97 41bc99c
Merge branch 'main' into menu
ryanbarlow97 e911316
fix language for lobbies
ryanbarlow97 7a185eb
fix input modal for username/clan tag
ryanbarlow97 c31ab39
fix spanning
ryanbarlow97 f33c9fc
Merge branch 'menu' of https://github.com/openfrontio/OpenFrontIO int…
ryanbarlow97 b0bb015
fix: Critical accessibility violation: zoom prevention blocks users w…
ryanbarlow97 947b3f5
fix Critical: FOUC prevention creates accessibility risk.
ryanbarlow97 4759b7c
hom page fixes
ryanbarlow97 1bf87b5
updated getEndTimerInput to use this.querySelector("#end-timer-value"…
ryanbarlow97 49bab45
ios fix attempt 1
ryanbarlow97 74697cf
Changed .onClose=${this.close} to .onClose=${this.close.bind(this)} s…
ryanbarlow97 cd6a66f
localisation
ryanbarlow97 8bba1c2
Added strict object check
ryanbarlow97 f1d76db
fix name
ryanbarlow97 9048847
changed to FlagInputModal
ryanbarlow97 5ae946d
onclose consistency (reset ui)
ryanbarlow97 9f4bf64
reset ui consistency
ryanbarlow97 7c6be62
fix lang
ryanbarlow97 8b6ade7
Merge main into menu, resolving conflicts in Matchmaking and en.json
ryanbarlow97 3489a04
tailwind v4 oops
ryanbarlow97 97eb45e
added keyboard accessibility to the Flag Selector
ryanbarlow97 5fa66b7
prettier
ryanbarlow97 e1a1f0e
timer fix
ryanbarlow97 083b07c
improved the type safety of the languageList
ryanbarlow97 5d6c47d
localisations
ryanbarlow97 f7e19d9
interactive hamburger button correctly references the sidebar menu
ryanbarlow97 68e4dd9
add aria
ryanbarlow97 2d9baa4
Fix type declaration to match validation logic
ryanbarlow97 c23a4fa
removed the non-null assertion
ryanbarlow97 7eaec29
change public lobby ring to blue
ryanbarlow97 c97aaef
change names to white
ryanbarlow97 1c15d84
modernise join lobby modal
ryanbarlow97 63c8c98
hasanystats check
ryanbarlow97 835d7b8
prettier fix
ryanbarlow97 9c1e439
remove keyCode
ryanbarlow97 3642f1d
Add an early-exit check
ryanbarlow97 589290f
text colour fix
ryanbarlow97 5e632f2
prettier
ryanbarlow97 e0a059f
fix
ryanbarlow97 a9cdff6
prettier
ryanbarlow97 dcf5b85
prettier fix
ryanbarlow97 e683344
fix the ESLint error
ryanbarlow97 e944f22
removed borked account button
ryanbarlow97 88b8116
click outside modal to go back
ryanbarlow97 9166301
update keybind display for localisations
ryanbarlow97 4260442
Merge branch 'main' into menu
ryanbarlow97 d94d618
reset logic fix
ryanbarlow97 12bef88
default page to page-play
ryanbarlow97 30cb228
Consolidated the initialixation logic.
ryanbarlow97 73b6d00
cosmetics
ryanbarlow97 756fc02
Tighten the type guard logic
ryanbarlow97 71dd0ef
cleanup for the window event listener
ryanbarlow97 151b90d
change skin modal to not be white
ryanbarlow97 ad51dbf
Merge branch 'main' into menu
ryanbarlow97 b6a7261
test skin
ryanbarlow97 5194b99
remove weird fadein issue
ryanbarlow97 8fc73d9
use en.json
ryanbarlow97 3f8920c
removed uuid
ryanbarlow97 0e33a9a
localisations
ryanbarlow97 9c9555d
Merge main into testaskin
ryanbarlow97 5da49b0
remove logs
ryanbarlow97 d4b9cde
tests
ryanbarlow97 1a4ba86
fix timer
ryanbarlow97 c1cd919
added accessibility attributes
ryanbarlow97 63d3069
reset rated back to null
ryanbarlow97 23fb8e8
cleanup for the skin-test “initial attack” retry timer so it can’t fi…
ryanbarlow97 f5b83b9
Removed the unused skinTestTimeout field
ryanbarlow97 e6ec868
Merge branch 'main' into testaskin
ryanbarlow97 5f72df2
remove console
ryanbarlow97 1cef169
Self-clearing timeout is a no-op.
ryanbarlow97 d3b90c3
remove unused eventmus
ryanbarlow97 ed345e2
Merge branch 'main' into testaskin
ryanbarlow97 f921e83
fix build
ryanbarlow97 b6ebad6
Merge branch 'main' into testaskin
ryanbarlow97 0423b38
Merge branch 'main' into testaskin
evanpelle 5ea429f
Merge branch 'main' into testaskin
ryanbarlow97 b7ea630
move logic into modal
ryanbarlow97 c84fc4a
new TestSkinExecution.ts that starts an attack
ryanbarlow97 c65bed8
need to carry over the userid to show winmodal
ryanbarlow97 181324d
Stop skin-test resources on show; add stopSkinTest helper and use it …
ryanbarlow97 9c1abd7
moved stuff out of clientgamerunner
ryanbarlow97 4ce8fa2
test
ryanbarlow97 d411c78
Merge branch 'main' into testaskin
ryanbarlow97 aa4f43d
Merge branch 'main' into testaskin
ryanbarlow97 197960e
conflict res
ryanbarlow97 e981ecc
Merge branch 'main' into testaskin
ryanbarlow97 f0d6e30
Merge branch 'main' into testaskin
ryanbarlow97 4878737
Merge branch 'main' into testaskin
ryanbarlow97 bda3961
Merge branch 'main' into testaskin
ryanbarlow97 f81e990
change to "preview skin"
ryanbarlow97 b3b405c
update wording
ryanbarlow97 6c65d25
Merge branch 'main' into testaskin
ryanbarlow97 e5ad3cc
Merge branch 'main' into testaskin
ryanbarlow97 73159c7
fixed missing }
ryanbarlow97 074b2c0
Merge branch 'main' into testaskin
ryanbarlow97 af2fe78
call stop instead
ryanbarlow97 9d19396
Merge branch 'main' into testaskin
ryanbarlow97 3101b73
Merge branch 'main' into testaskin
ryanbarlow97 f3d0fab
comment
ryanbarlow97 e549f38
updates
ryanbarlow97 dffed45
rabbit
ryanbarlow97 480fd7b
Merge branch 'main' into testaskin
ryanbarlow97 470eb52
updated for new build
ryanbarlow97 571ad9c
Merge branch 'main' into testaskin
ryanbarlow97 b0a6992
Merge branch 'main' into testaskin
ryanbarlow97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.