Skip to content

Add ion capabilities #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Add ion capabilities #146

merged 8 commits into from
Oct 17, 2024

Conversation

lilyminium
Copy link
Collaborator

@lilyminium lilyminium commented Oct 17, 2024

Fixes #138

Changes made in this Pull Request:

  • This puts in necessary technical fixes to allow NAGL to work with ions. The PR needed to copy over code from DGL; we should revisit if combine_frames doesn't allow for no edges dmlc/dgl#7826 is fixed.
  • It also adds tests for an "rc4", which is the rc3 model of NAGL1 manually modified to accept atoms with 0 bonds as a feature (weights are set to 0). The tests test that for real molecules we get the same charges out as rc3, but also adds / un-xfails some ion tests.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 44 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (1d7e4ff) to head (8be0f3c).
Report is 1 commits behind head on main.

Additional details and impacted files

@lilyminium
Copy link
Collaborator Author

Attribution and licensing that part under Apache 2.0 should be sufficient I think? https://law.stackexchange.com/questions/59999/can-i-copy-pieces-of-apache-licensed-source-code-if-i-attribute

@lilyminium lilyminium merged commit 6cb4387 into main Oct 17, 2024
1 check was pending
@lilyminium lilyminium deleted the make-ion-friendly branch October 17, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NAGL won't charge single ions
2 participants