Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clarify next step on error page #416

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −4
Open

fix: Clarify next step on error page #416

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ef4a8c
fix: error page
teolemon Feb 15, 2024
0bf1b89
Update index.tsx
teolemon Feb 15, 2024
0e1426b
fix formatting
perierc Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions taxonomy-editor-frontend/src/pages/errors/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ const Errors = ({ addNavLinks }) => {
<Table style={{ border: "solid", borderWidth: 1.5 }}>
<TableHead>
<TableCell align="left">
<Typography variant="h6">Taxonomy Name</Typography>
<Typography variant="h6">Taxonomy name</Typography>
</TableCell>
<TableCell align="left">
<Typography variant="h6">Branch Name</Typography>
<Typography variant="h6">Branch name</Typography>
</TableCell>
</TableHead>
<TableBody>
Expand All @@ -105,7 +105,9 @@ const Errors = ({ addNavLinks }) => {
{errors.length > 0 && (
<>
<Alert severity="warning">
These errors must be fixed manually via Github!
These errors must be fixed manually first, by creating a cleanup
PR on GitHub:
https://github.com/openfoodfacts/openfoodfacts-server/tree/main/taxonomies
</Alert>
<Box
sx={{
Expand Down Expand Up @@ -135,7 +137,8 @@ const Errors = ({ addNavLinks }) => {
)}
{errors.length === 0 && (
<Typography>
No Error, {toTitleCase(taxonomyName || "")} can be edited
✅ Well done! No errors: {toTitleCase(taxonomyName || "")} can be
edited
</Typography>
)}
</Stack>
Expand Down
Loading