Skip to content

feat: Product addition test #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

abughalib
Copy link
Contributor

What

Added Unit Test for Product Addition.

Part of

#1176

@abughalib abughalib requested a review from a team as a code owner October 25, 2022 14:37
@abughalib abughalib changed the title product addition test Test: Product addition test Oct 25, 2022
@abughalib abughalib changed the title Test: Product addition test feat: Product addition test Oct 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3216 (b68393e) into develop (78740d3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #3216   +/-   ##
=======================================
  Coverage     6.21%   6.21%           
=======================================
  Files          253     253           
  Lines        12487   12487           
=======================================
  Hits           776     776           
  Misses       11711   11711           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AshAman999 AshAman999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong here but it seems like this should be on the off-dart package repo, you are just checking the OpenfoodApi client's responses not how it's actually saved on the app

@abughalib
Copy link
Contributor Author

@AshAman999 Good Point.
Testing the database would make more sense.

@M123-dev
Copy link
Member

Yeah I agree with @AshAman999 we should keep these tests in the other repository, the tests here should more be for the UI and UX of the app not for the raw product tests.

@abughalib abughalib closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants