Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added Fitted Box for food preferences text shrinking #1412

Merged
merged 8 commits into from
Mar 30, 2022
Merged

fix: Added Fitted Box for food preferences text shrinking #1412

merged 8 commits into from
Mar 30, 2022

Conversation

Gagarod
Copy link
Contributor

@Gagarod Gagarod commented Mar 29, 2022

What

  • Text in button on smaller screens goes in two lines has been fixed

Screenshot

Before After
Before After

Fixes bug(s)

Part of

@Gagarod Gagarod requested a review from a team as a code owner March 29, 2022 21:10
@Gagarod Gagarod closed this Mar 29, 2022
@Gagarod Gagarod reopened this Mar 29, 2022
@M123-dev M123-dev linked an issue Mar 29, 2022 that may be closed by this pull request
(Preferences) Text in button in smaller screens goes in two lines #900
Closed
@M123-dev M123-dev changed the title Fitted Box added for text shrinking fix: Added Fitted Box for food preferences text shrinking Mar 29, 2022
@M123-dev
Copy link
Member

M123-dev commented Mar 29, 2022 •
edited
Loading

Heyy thanks @Gagarod, this PR has some merge conlifcts which have to be resolved.
And another thing for future PR's: Github also shows your changes from adding the Hero widget in this PR. It would be easier to review if you always start from a clear branch when working on something new

@Gagarod
Copy link
Contributor Author

Gagarod commented Mar 30, 2022

@M123-dev The merge conflicts have been resolved

@M123-dev
Copy link
Member

Looks good, thanks @Gagarod

@M123-dev M123-dev merged commit 9ef1c48 into openfoodfacts:develop Mar 30, 2022
@github-actions github-actions bot mentioned this pull request Mar 30, 2022
Closed
@stephanegigandet
Copy link
Contributor

Reported on the #smooth-app Slack channel: the buttons now have different sizes, I'm guessing it's related to this PR.

image

@abhay1821
Copy link
Contributor

abhay1821 commented Apr 1, 2022 •
edited
Loading

Hi @M123-dev @stephanegigandet,
If it's free to take So can you please reopen this issue? I will fix text-overflow problems with the same size of each button

@abhay1821 abhay1821 mentioned this pull request Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⚙️ Settings
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Preferences) Text in button in smaller screens goes in two lines
5 participants
@Gagarod @M123-dev @stephanegigandet @abhay1821 @teolemon