Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve resources caching #1492

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

raphael0202
Copy link
Collaborator

  • use a cache registry to know which functions are cached and to clear all cache easily
  • clear all cache after request in api
  • upgrade isort

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 92.42424% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.94%. Comparing base (946c73b) to head (2ad1c2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
robotoff/utils/cache.py 78.57% 3 Missing ⚠️
...y/neural/keras_category_classifier_3_0/__init__.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
+ Coverage   54.68%   54.94%   +0.25%     
==========================================
  Files          85       85              
  Lines        8800     8855      +55     
==========================================
+ Hits         4812     4865      +53     
- Misses       3988     3990       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 merged commit bb72dce into main Dec 9, 2024
9 checks passed
@raphael0202 raphael0202 deleted the improve-resources-caching branch December 9, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant