Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix nutrition extraction insight generation #1438

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

raphael0202
Copy link
Collaborator

  • use exaclly the same nutrient name format as in Open Food Facts
  • import nutrition_extraction insight if it brings at least one nutrient that was not in the product current nutrients.
  • add unit tests for the import mechanism

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.74%. Comparing base (b533199) to head (1eb09ef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
+ Coverage   54.65%   54.74%   +0.09%     
==========================================
  Files          85       85              
  Lines        8625     8634       +9     
==========================================
+ Hits         4714     4727      +13     
+ Misses       3911     3907       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 merged commit cfdfb07 into main Oct 25, 2024
9 checks passed
@raphael0202 raphael0202 deleted the nutrition-extraction branch October 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant