feat: batch job spellcheck #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… processing operational
…ction with DuckDB and launch on GCP .
There's no reason to configure the launch from endpoint. So we put in CLI instead of manual launch
Simplify abstractions - Change data in insights instead of value - Other small changes
Enhance batch extraction with popularity_key - Add env variables to batch job - Add make deploy Spellcheck job to Artifact registry
We concluded that PREDICTOR-VERSION will be used to track batch jobs and allow new data predictions to be imported. In the future, we'll find a way to detect already processed data in another way, such as before the batch job during the extraction stage.
github-actions
bot
added
🧪 tests
insights
🐋 Docker
Robotoff - App
Robotoff - CLI
🧪 unit tests
labels
raphael0202
force-pushed
the
batch-job-spellcheck
branch
from
0d9d34a to
e0d0bfa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
- Coverage 56.05% 55.65% -0.40%
==========================================
Files 80 84 +4
Lines 8012 8254 +242
==========================================
+ Hits 4491 4594 +103
- Misses 3521 3660 +139 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #1401 had merge conflict, this is the same + some pypy/flake8 fixes.