Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove matcher predictor completely #1253

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Conversation

raphael0202
Copy link
Collaborator

Remove completely the matcher predictor from code. I also removed SpaCy dependency as we don't need it anymore.
Furthermore, we now clear all ingredient processing cache after calling neural model in the API, which reduces memory consumption.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1253 (5b95045) into main (dac8e22) will decrease coverage by 0.14%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
- Coverage   56.59%   56.45%   -0.14%     
==========================================
  Files          79       78       -1     
  Lines        8116     7935     -181     
==========================================
- Hits         4593     4480     -113     
+ Misses       3523     3455      -68     
Files Changed Coverage Δ
robotoff/app/api.py 48.16% <ø> (+0.39%) ⬆️
robotoff/app/schema.py 100.00% <ø> (ø)
robotoff/insights/importer.py 83.35% <ø> (ø)
robotoff/prediction/category/__init__.py 57.14% <0.00%> (+25.56%) ⬆️
.../prediction/category/neural/category_classifier.py 82.92% <ø> (ø)
robotoff/settings.py 91.94% <ø> (-0.16%) ⬇️
robotoff/utils/text/__init__.py 100.00% <ø> (+6.25%) ⬆️
...ral/keras_category_classifier_3_0/preprocessing.py 84.48% <33.33%> (-1.36%) ⬇️
...y/neural/keras_category_classifier_3_0/__init__.py 73.45% <50.00%> (-0.30%) ⬇️
robotoff/prediction/ocr/product_weight.py 81.96% <100.00%> (+0.45%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raphael0202 raphael0202 merged commit 279ced1 into main Aug 31, 2023
11 of 12 checks passed
@raphael0202 raphael0202 deleted the remove-matcher-predictor branch August 31, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant