feat: 1011 - new "getPriceProducts" method #1012
Open
+278
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `get_price_products_order.dart`: Field for the "order by" clause of "get price products". * `get_price_products_parameters.dart`: Parameters for the "get price products" API query. * `get_price_products_result.dart`: List of price product objects returned by the "get price products" method. * `get_price_products_result.g.dart`: generated Impacted files: * `api_prices_test.dart`: new tests around new `getPriceProducts` method; minor refactoring * `get_parameters_helper.dart`: minor refactoring * `open_prices_api_client.dart`: new `getPriceProducts` method * `openfoodfacts.dart`: exported the new 3 files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1012 +/- ##
==========================================
- Coverage 76.34% 75.88% -0.47%
==========================================
Files 239 255 +16
Lines 8494 9546 +1052
==========================================
+ Hits 6485 7244 +759
- Misses 2009 2302 +293 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of
Files
New files:
get_price_products_order.dart: Field for the "order by" clause of "get price products".get_price_products_parameters.dart: Parameters for the "get price products" API query.get_price_products_result.dart: List of price product objects returned by the "get price products" method.get_price_products_result.g.dart: generatedImpacted files:
api_prices_test.dart: new tests around newgetPriceProductsmethod; minor refactoringget_parameters_helper.dart: minor refactoringopen_prices_api_client.dart: newgetPriceProductsmethodopenfoodfacts.dart: exported the new 3 files