Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(master): release 3.18.0 #1001

Merged

Conversation

openfoodfacts-bot
Copy link
Collaborator

@openfoodfacts-bot openfoodfacts-bot commented Nov 25, 2024

🤖 I have created a release beep boop

3.18.0 (2024-11-29)

Features

  • 995 - support of the new "product type" filter for "get product" (#1004) (032a547)
  • 999 - added "bool? product.isImageLocked" method (#1000) (8a01b5c)

Bug Fixes


This PR was generated with Release Please. See documentation.

@openfoodfacts-bot openfoodfacts-bot requested a review from a team as a code owner November 25, 2024 15:32
@openfoodfacts-bot openfoodfacts-bot force-pushed the release-please--branches--master--components--openfoodfacts branch 2 times, most recently from 30c18c3 to 117518e Compare November 28, 2024 20:02
@openfoodfacts-bot openfoodfacts-bot force-pushed the release-please--branches--master--components--openfoodfacts branch from 117518e to 3f51359 Compare November 29, 2024 17:27
@monsieurtanuki
Copy link
Contributor

@g123k @teolemon I guess it'd be OK to publish off-dart as of now, wouldn't it?

I'd do it now but I'm busy, and there are minor but important (!) actions to perform on Smoothie if we want to upgrade:

  • support of the new "product type" filter for "get product"
    => labeled "P0" - we should remove the loop on all servers in Smoothie
  • added "bool? product.isImageLocked" method
    => no rush, add new product field OWNER to ProductQuery.fields, cf. Locked products  smooth-app#5394
  • contributor correctly displayed
    => nothing to do, just refresh the product if needed
  • for online price locations, no OSM fields
    => additional mandatory null check for prices

@g123k
Copy link
Contributor

g123k commented Nov 29, 2024

@g123k @teolemon I guess it'd be OK to publish off-dart as of now, wouldn't it?

I'd do it now but I'm busy, and there are minor but important (!) actions to perform on Smoothie if we want to upgrade:

  • support of the new "product type" filter for "get product"
    => labeled "P0" - we should remove the loop on all servers in Smoothie
  • added "bool? product.isImageLocked" method
    => no rush, add new product field OWNER to ProductQuery.fields, cf. Locked products  smooth-app#5394
  • contributor correctly displayed
    => nothing to do, just refresh the product if needed
  • for online price locations, no OSM fields
    => additional mandatory null check for prices

All comments are duly noted.
We'll open tickets so we don't forget anything.

@g123k g123k merged commit c5fec85 into master Nov 29, 2024
4 of 5 checks passed
@g123k g123k deleted the release-please--branches--master--components--openfoodfacts branch November 29, 2024 19:25
@openfoodfacts-bot
Copy link
Collaborator Author

🤖 Created releases:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants