refactor(prices): reorganise schema inheritance to validate price updates #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
force-pushed
the
raphodn/price-schema-update-validation
branch
from
b9b60b0 to
de4ebc4
Compare
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently we don't have any validation on
PriceBasicUpdatableFields, so a user could add a negative price...Related to this comment : openfoodfacts/openfoodfacts-dart#942 (comment)
How
PriceBaseschemaPriceBasicUpdatableFieldstoPriceUpdatePriceUpdateoptional (for the PATCH method)Todo
It still doesn't validate the edition of the
price_perfield, because it relies on fields (product_code,category_tags) that are not available in thePriceBaseschema... 🤔Useful links