Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: yaml tests bug #1048

Merged
merged 2 commits into from
Oct 6, 2021
Merged

fix: yaml tests bug #1048

merged 2 commits into from
Oct 6, 2021

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Sep 29, 2021 •
edited
Loading

Depended upon by #1058

Bug fix

  • In test_yaml.py:
    • Fix yaml tests loading —required for testing against the built version.

@bonjourmauko bonjourmauko added the kind:fix Bugs are defects and failure demand. label Sep 29, 2021
@bonjourmauko bonjourmauko requested a review from a team September 29, 2021 01:21
@bonjourmauko bonjourmauko added this to the Improve testing & releases milestone Sep 29, 2021
@bonjourmauko bonjourmauko added the kind:theme A group of issues, directly tied to an OKR label Sep 29, 2021
@bonjourmauko bonjourmauko modified the milestones: Improve testing & releases, Improved releases Sep 29, 2021
@bonjourmauko bonjourmauko added the kind:roadmap A group of issues, constituting a delivery roadmap label Sep 29, 2021
@bonjourmauko bonjourmauko changed the title Fix yaml tests bug [1/2] Fix yaml tests bug Sep 29, 2021
@bonjourmauko bonjourmauko changed the title [1/2] Fix yaml tests bug [1/3] Fix yaml tests bug Oct 1, 2021
@bonjourmauko bonjourmauko mentioned this pull request Oct 1, 2021
Draft
@bonjourmauko bonjourmauko requested a review from MattiSG October 1, 2021 15:34
@bonjourmauko bonjourmauko changed the title [1/3] Fix yaml tests bug [1/3] [test-built] Fix yaml tests bug Oct 1, 2021
@bonjourmauko bonjourmauko mentioned this pull request Oct 1, 2021
Closed
@bonjourmauko bonjourmauko changed the title [1/3] [test-built] Fix yaml tests bug [1/4] [test-built] Fix yaml tests bug Oct 1, 2021
@bonjourmauko bonjourmauko mentioned this pull request Oct 1, 2021
Merged
2 tasks
MattiSG
MattiSG approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I fully understand how this fixes testing against the cached version (I assume that is because the current system uses pkg resources to access fixture data), but this looks cleaner, tests still pass, and there is the same number of tests run as before 🙂

@bonjourmauko
Copy link
Member Author

@MattiSG Exactly: pkg_resources will tell you where things were installed, which will no longer be the good place when retrieving the cache (site_packages ~ editable).

@bonjourmauko bonjourmauko merged commit 00bc61d into master Oct 6, 2021
@bonjourmauko bonjourmauko deleted the fix-yaml-test-bug branch October 6, 2021 08:30
@MattiSG
Copy link
Member

MattiSG commented Oct 7, 2021

Thanks @maukoquiroga! 👏

@bonjourmauko bonjourmauko removed kind:theme A group of issues, directly tied to an OKR kind:roadmap A group of issues, constituting a delivery roadmap labels Oct 7, 2021
@bonjourmauko bonjourmauko mentioned this pull request Oct 4, 2024
Open
6 tasks
@bonjourmauko bonjourmauko changed the title [1/4] [test-built] Fix yaml tests bug fix: yaml tests bug Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiSG MattiSG MattiSG approved these changes

Assignees
No one assigned
Labels
kind:fix Bugs are defects and failure demand.
Projects
None yet
Milestone
Improved releases
Development

Successfully merging this pull request may close these issues.
2 participants
@bonjourmauko @MattiSG