-
Notifications
You must be signed in to change notification settings - Fork 88
feat: enhance cli config file location documentation #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: enhance cli config file location documentation #1040
Conversation
b1dbbe7
to
e91a89c
Compare
Co-authored-by: Siddhant Khare <[email protected]>
WalkthroughThe documentation for the FGA CLI configuration file was updated to specify the prioritized search order and possible locations for the Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation updates. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/content/getting-started/cli.mdx (2)
22-23
: Avoid repetitive sentence starts for smoother readingThe three bullets in lines 20–23 all start with “Using …”. Re-phrasing one or two of them (e.g., “Via CLI flags”, “Environment variables”, “A
.fga.yaml
config file …”) removes the monotony and reads more naturally.
27-28
: Correct Windows environment-variable casingWindows environment variables are conventionally written in all-caps. Replace
%AppData%
with%APPDATA%
for accuracy and consistency with other docs.- * Windows: %AppData% + * Windows: %APPDATA%
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/content/getting-started/cli.mdx
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/content/getting-started/cli.mdx
[style] ~22-~22: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...flags. - Using environment variables. - Using a .fga.yaml
configuration file, searc...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: deploy-preview
- GitHub Check: markdown-link-check-md
- GitHub Check: markdown-link-check
- GitHub Check: Run Checks
- GitHub Check: Test deployment
Description
Add more clarity around the cli config file location documentation and update it with the latest change in in openfga/cli#504
References
Review Checklist
main
Summary by CodeRabbit
.fga.yaml
configuration file, detailing the prioritized search order and platform-specific paths.