fix: handle tiny exponential values in formatNumber - #251
Open
DeoJin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toFixed()by falling back to nativeNumber(...).toFixed()formatNumber()for very small values like1e-7so it returns a formatted zero instead ofNaNCloses #241.
Validation
node -e "const accounting=require('./accounting'); function assertEq(actual, expected, label){ if(actual!==expected){ console.error(label + ': expected ' + expected + ', got ' + actual); process.exit(1);} } assertEq(accounting.formatNumber(0.615, 2), '0.62', 'rounding regression'); assertEq(accounting.formatNumber(1.005, 2), '1.01', 'rounding regression 2'); assertEq(accounting.formatNumber(1e-7, 2), '0.00', 'tiny positive'); assertEq(accounting.formatNumber(0.0000001, 6), '0.000000', 'tiny precision'); assertEq(accounting.formatNumber(-3e-23, 2), '-0.00', 'tiny negative'); console.log('validation-ok');"