Skip to content

fix: handle tiny scientific-notation values in formatNumber #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeoJin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle tiny scientific-notation values in formatNumber #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions accounting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,11 @@
var toFixed = lib.toFixed = function(value, precision) {
precision = checkPrecision(precision, lib.settings.number.precision);

var exponentialForm = Number(lib.unformat(value) + 'e' + precision);
var rounded = Math.round(exponentialForm);
var finalResult = Number(rounded + 'e-' + precision).toFixed(precision);
var shiftedExponentials = String(lib.unformat(value)).split('e');
var shiftedNumber = Number(shiftedExponentials[0] + 'e' + ((shiftedExponentials[1] ? Number(shiftedExponentials[1]) : 0) + precision));
var rounded = Math.round(shiftedNumber);
var roundedExponentials = String(rounded).split('e');
var finalResult = Number(roundedExponentials[0] + 'e' + ((roundedExponentials[1] ? Number(roundedExponentials[1]) : 0) - precision)).toFixed(precision);
return finalResult;
};

Expand Down
8 changes: 8 additions & 0 deletions tests/jasmine/core/formatNumberSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ describe('formatNumber', function(){

});

it('should format tiny numbers without returning NaN', function(){

expect( accounting.formatNumber(1e-7) ).toBe( '0' );
expect( accounting.formatNumber(0.0000001) ).toBe( '0' );
expect( accounting.formatNumber(1e-7, 8) ).toBe( '0.00000010' );

});

it('should work for large numbers', function(){

expect( accounting.formatNumber(123456.54321, 0) ).toBe( '123,457' );
Expand Down