Remove XModuleMixin legacy attibs from Poll and Discussion Block#224
Remove XModuleMixin legacy attibs from Poll and Discussion Block#224salman2013 merged 5 commits intomainfrom
Conversation
|
Thanks for the pull request, @salman2013! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| @@ -105,7 +105,7 @@ def discussion_config(self): | |||
|
|
|||
| @property | |||
| def course_key(self): | |||
There was a problem hiding this comment.
course_key property will be removed
There was a problem hiding this comment.
This property is used at multiple places, I have already updated 'self.scope_ids.usage_id' to 'self.usage_key' inside its returning value.
There was a problem hiding this comment.
As per story we should change its usage to context_key
.course_key -> .context_key
Description:
Remove XModuleMixin legacy attributes from Poll and Discussion Block.
Ticket:
#207
#211
Parent Ticket:
#125