Skip to content

Remove XModuleMixin legacy attibs from Poll and Discussion Block#224

Merged
salman2013 merged 5 commits intomainfrom
salman/update--legacy-attributes
Apr 2, 2026
Merged

Remove XModuleMixin legacy attibs from Poll and Discussion Block#224
salman2013 merged 5 commits intomainfrom
salman/update--legacy-attributes

Conversation

@salman2013
Copy link
Copy Markdown
Contributor

Description:

Remove XModuleMixin legacy attributes from Poll and Discussion Block.

Ticket:
#207
#211

Parent Ticket:
#125

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 31, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Mar 31, 2026

Thanks for the pull request, @salman2013!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 31, 2026
@salman2013 salman2013 marked this pull request as ready for review March 31, 2026 15:19
@salman2013 salman2013 requested a review from farhan March 31, 2026 17:42
@@ -105,7 +105,7 @@ def discussion_config(self):

@property
def course_key(self):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

course_key property will be removed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is used at multiple places, I have already updated 'self.scope_ids.usage_id' to 'self.usage_key' inside its returning value.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per story we should change its usage to context_key

.course_key -> .context_key

@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Apr 1, 2026
@salman2013 salman2013 requested a review from farhan April 2, 2026 07:03
Copy link
Copy Markdown
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work
LGTM!

@salman2013 salman2013 merged commit 0dd64cd into main Apr 2, 2026
12 of 14 checks passed
@salman2013 salman2013 deleted the salman/update--legacy-attributes branch April 2, 2026 07:24
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants