Skip to content

revert: quoting of resource_link_id to align with LTI spec#623

Merged
Faraz32123 merged 1 commit intoopenedx:masterfrom
open-craft:navin/revert-resource-link-id-encoding
Mar 17, 2026
Merged

revert: quoting of resource_link_id to align with LTI spec#623
Faraz32123 merged 1 commit intoopenedx:masterfrom
open-craft:navin/revert-resource-link-id-encoding

Conversation

@navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Mar 16, 2026

Description:

This reverts commit 2b5fc5c and parts of f78cce7.

More information can be found in #621

Related issue: #621

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 16, 2026
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 16, 2026

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @Faraz32123.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Mar 16, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 16, 2026
@navinkarkera navinkarkera marked this pull request as ready for review March 16, 2026 09:40
@navinkarkera navinkarkera force-pushed the navin/revert-resource-link-id-encoding branch from 03a429c to 0ef474f Compare March 16, 2026 09:41
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.59%. Comparing base (c3f5a6e) to head (0ef474f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   97.60%   97.59%   -0.01%     
==========================================
  Files          79       79              
  Lines        6876     6871       -5     
==========================================
- Hits         6711     6706       -5     
  Misses        165      165              
Flag Coverage Δ
unittests 97.59% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@navinkarkera navinkarkera moved this from Needs Triage to Ready for Review in Contributions Mar 16, 2026
@rpenido
Copy link

rpenido commented Mar 16, 2026

LGTM 👍
Thank you for your work, @navinkarkera!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Comment on lines 69 to 72
def validate(self, attrs):
if attrs.get('resource_id') is None and attrs.get('resource_link_id') is None:
raise serializers.ValidationError("Must provide at least one of resource_id or resource_link_id")
return attrs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this validation, as we are reverting both PRs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Faraz32123 No, we are just removing quoting of location/usage_keys.

@Faraz32123 Faraz32123 merged commit 9dd2430 into openedx:master Mar 17, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Mar 17, 2026
@Faraz32123 Faraz32123 mentioned this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants