revert: quoting of resource_link_id to align with LTI spec#623
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
… tools (openedx#607)" This reverts commit 2b5fc5c.
03a429c to
0ef474f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #623 +/- ##
==========================================
- Coverage 97.60% 97.59% -0.01%
==========================================
Files 79 79
Lines 6876 6871 -5
==========================================
- Hits 6711 6706 -5
Misses 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM 👍
|
| def validate(self, attrs): | ||
| if attrs.get('resource_id') is None and attrs.get('resource_link_id') is None: | ||
| raise serializers.ValidationError("Must provide at least one of resource_id or resource_link_id") | ||
| return attrs |
There was a problem hiding this comment.
Do we still need this validation, as we are reverting both PRs?
There was a problem hiding this comment.
@Faraz32123 No, we are just removing quoting of location/usage_keys.
Description:
This reverts commit 2b5fc5c and parts of f78cce7.
More information can be found in #621
Related issue: #621