Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @kingoftech-v01! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The custom session serializer at openedx/core/lib/session_serializers.py handed every stored session blob straight to the standard-library object deserializer, creating a CWE-502 unsafe-deserialization sink. A blanket switch to JSONSerializer is not yet possible because CourseMasquerade, Decimal donation amounts and base64 third-party-auth pipeline bytes still flow through request.session. Wrap the object serializer with an HMAC-SHA256 signature derived from SECRET_KEY and verify it in constant time before any deserialisation. Unsigned or tampered payloads raise SuspiciousOperation, which Django's session backend converts into an empty session (forced re-login). This makes the deserialisation sink unreachable to any attacker who does not already hold SECRET_KEY, and adds a defense-in-depth layer on top of Django's own signing.loads wrapper. Operators should note that active sessions will be invalidated once on upgrade and users will need to log in again; no data is lost. The class name and import path are preserved so openedx/envs/common.py and any downstream forks do not need updates.
3 participants
Closed.