Conversation
|
Thanks for the pull request, @kingoftech-v01! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
IsUserInUrlOrStaff.has_permission returned the expression `IsStaff | IsUserInUrl`, which under DRF 3.9+ evaluates to a composite permission class object rather than a boolean. A class object is always truthy, so the permission check unconditionally granted access to any authenticated caller regardless of whether the request user matched the username in the URL or held staff status. The defect was introduced in PR #28663 (Oct 2021, commit 9e787a0) when the dependency on rest_condition was removed: `C(IsStaff) | IsUserInUrl` was replaced with `IsStaff | IsUserInUrl` under the assumption that native DRF composition would apply, but native composition only works at the view-level permission_classes attribute, not inside a has_permission method body. Exploitation was prevented in practice by a defense-in-depth check in openedx/core/djangoapps/user_api/preferences/api.py::_check_authorized, which independently rejects cross-user access. This fix restores the intended behaviour at the DRF layer so the API no longer relies solely on the internal check. Instantiate IsStaff and IsUserInUrl and delegate to their has_permission methods, OR-ing the boolean results. Adds regression tests for staff, owner-matching, mismatched, and anonymous cases.
3 participants
Closed.