Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @kingoftech-v01! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The /debug/run_python and /debug/show_parameters URLs are developer aids and must never be reachable from a production image. run_python was already guarded by the ENABLE_DEBUG_RUN_PYTHON feature flag (default False) and runs inside CodeJail safe_exec, but relying on a single FEATURES toggle for a code-execution surface is insufficient defence-in-depth. show_parameters was registered unconditionally and only required @login_required, so any authenticated learner could hit it and echo arbitrary URL parameters back to themselves. Move both URL registrations inside `if settings.DEBUG:` so they are compiled out of production URL resolution entirely, keep the existing ENABLE_DEBUG_RUN_PYTHON flag for run_python, and add an is_staff check inside show_parameters as a last-line guard in case the URL is ever re-exposed by misconfiguration.
3 participants
Closed.