fix: resolve OLX pointer tags for external XBlocks at runtime level#38328
fix: resolve OLX pointer tags for external XBlocks at runtime level#38328kingoftech-v01 wants to merge 1 commit intoopenedx:masterfrom
Conversation
Previously, built-in XBlocks (problem, video, vertical, etc.) could be
imported and exported using pointer-tag OLX syntax, but externally-defined
XBlocks (e.g. drag-and-drop-v2, lti_consumer, ORA) could only be imported
inline. Pointer-tag handling lived exclusively on XmlMixin, which is not
inherited by external blocks and is deliberately excluded from
settings.XBLOCK_MIXINS.
Move pointer-tag resolution out of XmlMixin and into two single
chokepoints on XMLParsingModuleStoreRuntime:
* xblock_from_node: detect is_pointer_tag and load the referenced file
before dispatching to parse_xml, but only when the target class does
not already inherit XmlMixin (to preserve existing behavior and
avoid double file reads).
* add_block_as_child_node: when exporting a non-XmlMixin block, write
its definition to a separate file and leave a pointer tag in the
parent, matching the export format used by built-in blocks.
This supersedes the per-container approach in the reverted PR openedx#37133,
which missed import paths outside of vertical/split_test/item_bank/
conditional and did not address the export side at all.
Closes openedx#36390
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @kingoftech-v01! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
3 participants
Withdrawn by author.
I submitted 36 pull requests in a short window and mass-tagged the maintenance working group. That was the wrong way to approach this repository. I apologise to @kdmccormick and to the
@openedx/wg-maintenance-openedx-platformmembers for the notification noise.For the security-related patches, I should have used the private disclosure channel at
security@openedx.orgrather than public pull requests. The original body of this PR included exploit paths and affected line numbers; that content has been removed here to avoid indexing. Any legitimate security finding will be re-reported privately through the proper channel.For the bug-fix patches, I plan to re-engage the community through the correct process: discussing on https://discuss.openedx.org first, then submitting one focused change per PR, and only tagging maintainers when a PR has passed CI and an individual reviewer asks to be involved.
No further action requested on this PR.