Skip to content

fix: withdrawn by author#38327

Closed
kingoftech-v01 wants to merge 1 commit intoopenedx:masterfrom
kingoftech-v01:fix/bug-36995
Closed

fix: withdrawn by author#38327
kingoftech-v01 wants to merge 1 commit intoopenedx:masterfrom
kingoftech-v01:fix/bug-36995

Conversation

@kingoftech-v01
Copy link
Copy Markdown

@kingoftech-v01 kingoftech-v01 commented Apr 10, 2026 •
edited
Loading

Closed.

@kingoftech-v01
fix(olx): persist subsection prerequisites across export/import
47bf267 
Subsection gating metadata (required prereq, min_score, min_completion,
and the is_prerequisite flag) lives in the external edx-milestones
tables and was previously not serialized by OLX export. Re-importing a
course therefore silently lost every configured learning-path gate.

Serialize the gating metadata as attributes on the <sequential> element
in SequenceBlock.definition_to_xml so it survives a full round trip.
On import, rebuild the milestone relationships via
openedx.core.lib.gating.api, verify the referenced prerequisite block
actually exists in the target course, and raise CourseImportException
with a clear message otherwise. Re-imports first clear any stale
"requires" milestone so the target matches the OLX exactly (round-trip
fidelity). Both paths no-op when the course-level
enable_subsection_gating flag is off.

Closes #36995
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 10, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Apr 10, 2026

Thanks for the pull request, @kingoftech-v01!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 10, 2026
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Apr 10, 2026
@kingoftech-v01 kingoftech-v01 deleted the fix/bug-36995 branch April 10, 2026 20:59
@kingoftech-v01 kingoftech-v01 changed the title fix(olx): persist subsection prerequisites across export/import fix: withdrawn by author Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farhan farhan Awaiting requested review from farhan farhan is a code owner

@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram is a code owner

@salman2013 salman2013 Awaiting requested review from salman2013 salman2013 is a code owner

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kingoftech-v01 @openedx-webhooks @kdmccormick