fix(courseware): restore anonymous video viewing on public courses#38324
fix(courseware): restore anonymous video viewing on public courses#38324kingoftech-v01 wants to merge 1 commit intoopenedx:masterfrom
Conversation
Three distinct defects combined to break anonymous (unauthenticated) access to video blocks on public courses with the unenrolled-access waffle enabled: 1. CourseNavigationBlocksView.completions_dict queried BlockCompletion with request.user, which raised TypeError for AnonymousUser and returned a 500 from the navigation API. Short-circuit with an empty mapping for anonymous users. 2. _has_access_course.can_load did not bypass check_course_open_for_learner for anonymous users on public courses, so public courses with future start dates returned StartDateError and render_xblock converted it to a 404. Grant load access when the course is public and the waffle is enabled. 3. _has_access_to_block.can_load had the same gap at the block level, causing blocks with inherited future start dates to 404 even after the course-level check passed. Mirror the public-access bypass at the block level, keyed off the CourseOverview. Gating in all three sites reuses check_public_access, so the existing COURSE_ENABLE_UNENROLLED_ACCESS_FLAG + COURSE_VISIBILITY_PUBLIC contract continues to govern who sees what. Authenticated users, masquerading staff, and non-public courses are unaffected. Closes openedx#38019
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @kingoftech-v01! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
CLA signed via DocuSign. Re-triggering the check. Other checklist items:
@openedx/wg-maintenance-openedx-platform — marking ready for engineering review when you have capacity. Thanks! |
3 participants
Withdrawn by author.
I submitted 36 pull requests in a short window and mass-tagged the maintenance working group. That was the wrong way to approach this repository. I apologise to @kdmccormick and to the
@openedx/wg-maintenance-openedx-platformmembers for the notification noise.For the security-related patches, I should have used the private disclosure channel at
security@openedx.orgrather than public pull requests. The original body of this PR included exploit paths and affected line numbers; that content has been removed here to avoid indexing. Any legitimate security finding will be re-reported privately through the proper channel.For the bug-fix patches, I plan to re-engage the community through the correct process: discussing on https://discuss.openedx.org first, then submitting one focused change per PR, and only tagging maintainers when a PR has passed CI and an individual reviewer asks to be involved.
No further action requested on this PR.