fix: read latest CSRF token from cookie#38272
fix: read latest CSRF token from cookie#38272asadali145 wants to merge 3 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @asadali145! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Are there tests for this? Is that even possible? |
@pdpinch There are no existing tests, that's why I skipped that part. |
|
Is this going to add overhead to every ajax request? |
Issue Links
https://github.com/mitodl/hq/issues/10704
Description
Fixes intermittent 403 CSRF errors encountered by learners when submitting problem answers in the Learning MFE.
The Learning MFE renders course units inside an LMS-served iframe. When a learner submits a problem, the page sends POST requests to the LMS (e.g.,
/eventand/courses/{course_key}/xblock/{usage_key}/handler/xmodule_handler/problem_check). These requests require a valid CSRF token in theX-CSRFTokenheader.Root Cause
The CSRF token was being cached at page load:
$.cookie('csrftoken')was read once when the iframe loadedServer logs confirmed:
Fix
Update AJAX setup to read the CSRF cookie immediately before each unsafe same-origin request (via
beforeSend) instead of caching it at load time.This ensures:
X-CSRFTokenheader always matches the latestcsrftokencookieImpact
Testing Instructions
Reproduction Steps
Expected Behavior
Before fix:
After fix:
Additional Verification
problem_checkrequestX-CSRFTokenheader matches currentcsrftokencookieRegression Checks