fix: add weight from max_weight if its missing from meta#38252
fix: add weight from max_weight if its missing from meta#38252marslanabdulrauf wants to merge 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @marslanabdulrauf! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Related Ticket
https://github.com/mitodl/hq/issues/9447 (MIT Internal)
Description
This pull request introduces a new helper function to improve how problem block metadata is handled, specifically ensuring that the correct
weightvalue is shown for problem blocks when it has not been explicitly set. The changes also include comprehensive unit tests for this new logic.Enhancements to problem block metadata handling:
_get_metadata_with_problem_defaultsinview_handlers.pyto inject aweightvalue into problem block metadata when it is missing, usingmax_score()as the default. This prevents the frontend from defaulting to 1 when the actual point value is different.get_block_infofunction to use_get_metadata_with_problem_defaultsinstead ofown_metadata, ensuring the new logic is applied wherever block info is retrieved.Testing improvements:
TestGetMetadataWithProblemDefaultsintest_block.pyto verify the behavior of the helper function, covering scenarios for problem blocks with and without explicit weights, as well as non-problem blocks.test_block.pyto include_get_metadata_with_problem_defaultsfor testing.Testing instructions