Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #343

Merged
merged 8 commits into from
Jul 31, 2023

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Jun 12, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17 along with react-test-renderer to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated paragon to fix react-loading-skeleton issue
  • Updated edx packages @edx/frontend-platform

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a935d29) 90.34% compared to head (cc4a7cc) 90.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files         226      226           
  Lines        4018     4018           
  Branches      797      797           
=======================================
  Hits         3630     3630           
  Misses        369      369           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review July 5, 2023 11:49
Copy link
Contributor

@kenclary kenclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, looks right

@kenclary kenclary merged commit 38b85f7 into openedx:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants