Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update font awesome to v6 (major) #823

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 31, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@fortawesome/fontawesome-svg-core (source) 1.2.36 -> 6.5.1 age adoption passing confidence
@fortawesome/free-brands-svg-icons (source) 5.15.4 -> 6.5.1 age adoption passing confidence
@fortawesome/free-regular-svg-icons (source) 5.15.4 -> 6.5.1 age adoption passing confidence
@fortawesome/free-solid-svg-icons (source) 5.15.4 -> 6.5.1 age adoption passing confidence

Release Notes

FortAwesome/Font-Awesome (@​fortawesome/fontawesome-svg-core)

v6.5.1

Compare Source

v6.5.0

Compare Source

v6.4.2

Compare Source

Change log available at https://fontawesome.com/docs/changelog/

v6.4.0

Compare Source

Change log available at https://fontawesome.com/docs/changelog/

v6.3.0

Compare Source

Change log available at https://fontawesome.com/docs/changelog/

v6.2.1

Compare Source

Change log available at https://fontawesome.com/docs/changelog/

v6.2.0

Compare Source

Change log available at https://fontawesome.com/docs/changelog/

v6.1.2

Compare Source

Change log available at https://fontawesome.com/docs/changelog/

v6.1.1

Compare Source

Change log available at https://fontawesome.com/docs/changelog/

v6.1.0

Compare Source

Change log available at https://fontawesome.com/docs/changelog/


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/major-font-awesome branch 4 times, most recently from 1f850ba to 57ce3a9 Compare August 7, 2023 09:12
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 4 times, most recently from 73630a0 to 3511b00 Compare August 14, 2023 16:33
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 2 times, most recently from bc3fc07 to dc8e288 Compare August 21, 2023 13:46
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 2 times, most recently from 4fceb1d to a62f789 Compare September 4, 2023 09:56
@justinhynes
Copy link
Contributor

It looks like the tests are failing due to the JS in our component snapshots being stale. I opened up an internal ticket for us to update them in order to accept this update. Internal ticket: https://2u-internal.atlassian.net/browse/APER-2843.

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update needs additional work before we can accept it. See above comments in PR.

@justinhynes justinhynes added the blocked by other work PR cannot be finished until other work is complete label Sep 5, 2023
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 4 times, most recently from 7be540b to 0346f89 Compare September 11, 2023 17:01
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 5 times, most recently from ea1cdd8 to 6489e81 Compare September 18, 2023 16:53
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 5 times, most recently from e7582e3 to a733a01 Compare October 2, 2023 06:33
@renovate renovate bot force-pushed the renovate/major-font-awesome branch from a733a01 to 66f5d16 Compare October 2, 2023 09:42
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 4 times, most recently from 62a0b10 to d7645ab Compare December 11, 2023 16:42
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 5 times, most recently from 5893830 to c351bda Compare December 18, 2023 18:55
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 3 times, most recently from afeef34 to 06ef247 Compare December 25, 2023 13:56
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 2 times, most recently from 9ce2778 to bb29514 Compare January 1, 2024 12:58
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 4 times, most recently from da17fb6 to 2459a13 Compare January 15, 2024 15:17
@renovate renovate bot force-pushed the renovate/major-font-awesome branch 3 times, most recently from df4d5fe to bacf4bf Compare January 22, 2024 17:25
@renovate renovate bot force-pushed the renovate/major-font-awesome branch from bacf4bf to 6bbae1f Compare January 23, 2024 19:47
update jest snapshots
@deborahgu deborahgu requested a review from justinhynes January 24, 2024 21:34
@deborahgu deborahgu dismissed justinhynes’s stale review January 24, 2024 21:35

changes required by APER-2843: Update test snapshots for upgrade to fontawesome v6 are complete

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef5fe2f) 66.82% compared to head (5726470) 66.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files          52       52           
  Lines         850      850           
  Branches      176      176           
=======================================
  Hits          568      568           
  Misses        272      272           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deborahgu deborahgu merged commit fc75405 into master Jan 24, 2024
9 checks passed
@deborahgu deborahgu deleted the renovate/major-font-awesome branch January 24, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by other work PR cannot be finished until other work is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants