[do not merge] DEMO: design tokens and CSS variables #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
commented
Jun 8, 2023
| @@ -24,8 +24,8 @@ LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg | |||
| LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg | |||
| FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico | |||
| COLLECT_YEAR_OF_BIRTH=true | |||
| APP_ID='' | |||
| MFE_CONFIG_API_URL='' | |||
| APP_ID='profile' | |||
There was a problem hiding this comment.
Note: not explicitly necessary unless you opt to define PARAGON_THEME_URLS within the MFE configuration API in edx-platform.
adamstankiewicz
commented
Jun 8, 2023
package.json
Outdated
| @@ -27,11 +28,11 @@ | |||
| "extends @edx/browserslist-config" | |||
| ], | |||
| "dependencies": { | |||
| "@edx/brand": "npm:@edx/brand-openedx@1.2.0", | |||
| "@edx/brand": "npm:@edx/brand-edx.org@2.2.0-alpha.9", | |||
There was a problem hiding this comment.
TODO: will need to make similar changes to @edx/brand-openedx so that the correct files exist in that NPM package, too.
ghassanmas
reviewed
Sep 6, 2023
| * styles were modified to use Paragon's new CSS variables instead. | ||
| * | ||
| * See https://github.com/openedx/paragon/issues/2348 for more details. | ||
| */ | ||
| @import "~@edx/frontend-component-header/dist/index"; | ||
| @import "~@edx/frontend-component-footer/dist/footer"; | ||
|
|
There was a problem hiding this comment.
Can those be installed by their crossponding PRs?
ghassanmas
added a commit
to ghassanmas/frontend-app-learning
that referenced
this pull request
Oct 6, 2023
This PR purpose is to test/demo parago design tokens simliar to this one for the profile openedx/frontend-app-profile/pull/764 it override the following depns as seen in package.json - paragon alpha - openedx/frontend-build/pull/365 - openedx/frontend-platform/pull/440 - openedx/frontend-component-header/pull/351 - openedx/frontend-component-footer/pull/303 Conclousion so far: - There is an extra library that learning depends on which needs to support paragon; `frontend-lib-learning-assistant` and also `frontend-lib-special-exams` - It would be great to have a gudie or a document to look at, while doing the conversion that would **map variable from who it was used/named before to the name in design tokens** - I was stuck in the end with compliation error, that wepack couldn't find `Modal` exported from paragon.
|
I checked in with @adamstankiewicz today to see if this is a PR that needs to stay open. TL;DR -- yes, it should stay open for now. It is an important reference for other folks in the community who are working on implementing this feature in other frontends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates the usage of design tokens, CSS variables, and externally hosted CSS from
@edx/paragonwithin the frontend-app-profile MFE.It relies on:
PARAGONas a global variable frontend-build#365The branch for
@edx/frontend-buildPR above is installed into the profile MFE in this PR for demo purposes. However, you must configure@edx/frontend-platformto use a local checkout of that@edx/frontend-platformPR above for things to work properly: