Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed loading issue for wrong username #1139

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

sundasnoreen12
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 commented Nov 26, 2024

INF-1594

Description

I resolved an issue that occurred when navigating to the learner profile of a non-existent user. Previously, the user's page would display a perpetual "loading" spinner, but it now correctly displays the content of the "Not Found" page.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before
image

After
Screenshot 2024-11-25 at 5 19 55 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@sundasnoreen12 sundasnoreen12 requested a review from a team as a code owner November 26, 2024 11:29
@sundasnoreen12 sundasnoreen12 force-pushed the sundasMasterBranch-INF-1594 branch from 9105ea5 to c66face Compare November 26, 2024 11:33
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.90%. Comparing base (3270e27) to head (c66face).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/profile/data/sagas.js 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
+ Coverage   66.78%   66.90%   +0.11%     
==========================================
  Files          51       51              
  Lines         849      855       +6     
  Branches      175      177       +2     
==========================================
+ Hits          567      572       +5     
  Misses        272      272              
- Partials       10       11       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sundasnoreen12 sundasnoreen12 merged commit 53a52b8 into master Nov 26, 2024
7 of 8 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundasMasterBranch-INF-1594 branch November 26, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants