Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update translations for instructor toolbar and masquarade widget #961

Conversation

AnnHalii
Copy link

@AnnHalii AnnHalii commented Aug 11, 2022

Issue: #917

Description: Update translations for instructor toolbar and masquarade widget. I'm contributing on behalf of Raccoon Gang

Screen after adding changes(fr locale):
image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 11, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @AnnHalii! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

@natabene
Copy link

@AnnHalii Thank you for your contribution. Once you fill out the CLA forms and they are processed, I will confirm here and we will be able to review your code.

@natabene natabene changed the title fix: update translations for instructor toolbar and masquarade widget fix: update translations for instructor toolbar and masquarade widget Aug 30, 2022
@natabene natabene changed the title fix: update translations for instructor toolbar and masquarade widget fix: update translations for instructor toolbar and masquarade widget Sep 1, 2022
@natabene
Copy link

natabene commented Sep 1, 2022

@AnnHalii Are you still interested in pursuing this? If so, can you please submit the requested forms so we can review your code?

@e0d
Copy link

e0d commented Sep 15, 2022

@idegtiarov shoule @AnnHalii be covered under your CLA?

@natabene natabene changed the title fix: update translations for instructor toolbar and masquarade widget fix: update translations for instructor toolbar and masquarade widget Sep 19, 2022
@natabene natabene changed the title fix: update translations for instructor toolbar and masquarade widget fix: update translations for instructor toolbar and masquarade widget Sep 19, 2022
@natabene natabene changed the title fix: update translations for instructor toolbar and masquarade widget fix: update translations for instructor toolbar and masquarade widget Sep 23, 2022
@natabene natabene changed the title fix: update translations for instructor toolbar and masquarade widget fix: update translations for instructor toolbar and masquarade widget Sep 23, 2022
@natabene
Copy link

@AnnHalii We have not heard from you in a while, so I will close this for now.

@natabene natabene closed this Sep 27, 2022
@openedx-webhooks
Copy link

@AnnHalii Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@jciasenza
Copy link
Contributor

jciasenza commented Aug 12, 2024

I have taken this change in issue #1193

If you review it, it could be solved, thank you very much!!!
Sincerely
Juan Carlos (Aulasneo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants