-
Notifications
You must be signed in to change notification settings - Fork 270
fix: sidebar unitid undefined #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sidebar unitid undefined #1743
Conversation
Thanks for the pull request, @wgu-jesse-stewart! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes a bug where the active unit ID is null when viewing a locked unit by adding defensive checks in the handleUnitClick and checkBlockCompletion functions.
- Added a guard clause to return immediately in checkBlockCompletion if unitId is falsy.
- Updated handleUnitClick to verify both active and target sequences to prevent subsequent null pointer errors.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/courseware/data/thunks.js | Adds a null-check for unitId in checkBlockCompletion to avoid running side-effect methods when unitId is undefined. |
src/courseware/course/sidebar/sidebars/course-outline/hooks.js | Refactors the findSequenceByUnitId helper and adds checks in handleUnitClick to ensure both active and target sequences exist before dispatching actions. |
Sandbox deployment successful 🚀 |
Sandbox course for testing: |
Fixes #1747
This bug is due to activeUnitId being null when viewing a locked unit. The fix was to add some defensiveness to the handleUnitClick and checkBlockCompletion functions.
This prevents sendTrackEvent, sendTrackingLogEvent, checkBlockCompletion from running when navigating from a locked unit. If those methods need to run, even when the unit is locked, then we need to add some more logic to handle that state without throwing a null pointer error.
Sidebar-unitID-undefined.mp4