Course team main content#129
Conversation
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 81.79% 83.34% +1.55%
==========================================
Files 96 100 +4
Lines 1170 1201 +31
Branches 262 252 -10
==========================================
+ Hits 957 1001 +44
+ Misses 206 195 -11
+ Partials 7 5 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0e4278f to
9a3be80
Compare
9a3be80 to
3f8b7d0
Compare
f059fa8 to
408f8e3
Compare
wgu-jesse-stewart
left a comment
There was a problem hiding this comment.
Nice work. Here are my notes:
408f8e3 to
2fe28e4
Compare
2fe28e4 to
337592c
Compare
337592c to
3bf14d3
Compare
|
🎉 This PR is included in version 1.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
As part of this PR we are creating course team main layout, we have 2 tabs one for Members and one for Roles, we included the main table for members without working on actions as add/edit,etc.
Note:
Content of roles tab will be handled in a diff PR, same for filters and actions for members tab.
Supporting information
Closes #85
Testing instructions
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'