refactor: refactor Django view to DRF #37325
Open
+44
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mubbsharanwar
force-pushed
the
convert-enable_certificate_generation-drf
branch
4 times, most recently
from
55c1b28 to
433e582
Compare
hunzlahmalik
reviewed
Sep 4, 2025
mubbsharanwar
force-pushed
the
convert-enable_certificate_generation-drf
branch
3 times, most recently
from
15b3a29 to
4f548f4
Compare
hunzlahmalik
reviewed
Sep 8, 2025
Comment on lines
+483
to
+487
| certificates_enabled = serializers.BooleanField( | ||
| required=False, | ||
| default=False, | ||
| help_text="Enable or disable self-generated certificates for this course." | ||
| ) |
There was a problem hiding this comment.
Why have we removed source?
After that we wouldn't need this probably.
data = {
"certificates_enabled": request.data.get("certificates-enabled", False)
}There was a problem hiding this comment.
We added it initially to map certificates-enabled to certificates_enabled in the serializer, but that didn't work(the serializer was not making it a boolean and also not converting to snake case), so we prepared a data dict to pass it. We also have code reference for this approach.
Refactor enable_certificate_generation to class based EnableCertificateGenerationAPIView
mubbsharanwar
force-pushed
the
convert-enable_certificate_generation-drf
branch
from
4f548f4 to
7b774d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
enable_certificate_generationto class-basedEnableCertificateGenerationAPIView.