chore!: replace pytz with zoneinfo #37267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,7 +65,7 @@ def get_display_time_zone(time_zone_name): | |||
|
|
|||
| :param time_zone_name (str): Name of Pytz time zone | |||
| """ | |||
| time_zone = timezone(time_zone_name) | |||
| time_zone = ZoneInfo(time_zone_name) | |||
There was a problem hiding this comment.
Do we need to wrap this in a flag as well ?
| @@ -93,7 +93,7 @@ def get_seconds_since_epoch(date_time): | |||
| """ | |||
| if date_time is None: | |||
| return None | |||
| epoch = datetime.datetime.utcfromtimestamp(0).replace(tzinfo=pytz.utc) | |||
There was a problem hiding this comment.
Can we add a note in PR that utcfromtimestamp is being deprecated and thus we are changing it ?
Only to be done if it's being done across the platform.
Otherwise this can be ignored.
| @@ -189,7 +189,7 @@ def get_start_end_date(cadence_type): | |||
| start_date = end_date - datetime.timedelta(days=1, minutes=15) | |||
| if cadence_type == EmailCadence.WEEKLY: | |||
| start_date = start_date - datetime.timedelta(days=6) | |||
| return utc.localize(start_date), utc.localize(end_date) | |||
| return start_date.replace(tzinfo=get_utc_timezone()), end_date.replace(tzinfo=get_utc_timezone()) | |||
There was a problem hiding this comment.
Can we check if output of both these things is same ?
| @@ -205,7 +205,7 @@ def get_time_ago(datetime_obj): | |||
| """ | |||
| Returns time_ago for datetime instance | |||
| """ | |||
| current_date = utc.localize(datetime.datetime.today()) | |||
| current_date = datetime.datetime.now(get_utc_timezone()) | |||
There was a problem hiding this comment.
Can we check if output for both of these is same ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pytz got deprecated in Django 4.0 && has been completely removed in Django 5.0.
Django 4.2 had provided USE_DEPRECATED_PYTZ flag for pytz support which has now been completely removed in Django 5.0 as well.
Django now uses zoneinfo by default and datetime module use this under the hood now instead of pytz
Difference between datetime.timezone and zoneinfo
datetime.timezone and the zoneinfo package are both related to handling time zones in Python, but they serve slightly different purposes and have different use cases.
datetime.timezone
This is part of the standard library in Python.
It provides a simple way to represent a fixed offset from UTC (Coordinated Universal Time).
It doesn't have information about daylight saving time (DST) or historical changes in time zones.
It's suitable for scenarios where you only need to work with a constant offset, and historical changes in time zones are not important.
zoneinfo
The zoneinfo package is introduced in Python 3.9 as part of PEP 615.
It provides a more comprehensive and accurate way to handle time zones by including historical changes, daylight saving time transitions, and more.
It uses the IANA Time Zone Database, which is regularly updated to reflect changes in time zones around the world.
This package is suitable for applications that require precise handling of time zones, especially when dealing with historical dates.
Original Issue link:
#33980
Related PR:
#37148
Since it involves multiple files changes and as suggested in the PR planning to break that PR into multiple small PR.
Smaller PR link: