-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: add ability to override middlewares for recurring nudges #37265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to override middlewares for recurring nudges #37265
Conversation
Thanks for the pull request, @kaustavb12! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
2ee1a7a
to
8348783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: compared with open-craft/edx-platform#790, tested on a sandbox on open-craft/edx-platform#790
- I read through the code
- I checked for accessibility issues
- Includes documentation
- [N/A] Added to the Code Drift project board (for backports)
@kaustavb12 can you rebase the PR please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good why is the code coverage no passing? Can we fix that?
8348783
to
b42ae34
Compare
* feat: add ability to override middlewares for recurring nudges * feat: add ability to run command for all sites
b42ae34
to
15bda91
Compare
PR rebased. Not sure why code coverage was failing then, perhaps it was just being flaky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- ✅ I tested this on the devstack and it ran gracefully.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Description
This PR brings two changes to all the management commands based on SendEmailBaseCommand:
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Private Ref : BB-9883