-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Explore Courses button doesn't follow the same style conventions of MFE header #35994
Conversation
Thanks for the pull request, @jciasenza! This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Thanks @mphilbrick211 !!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @jciasenza . I've amended your commit message to be |
Thanks Kyle, I'm still working on the enzyme PR
…________________________________
De: Kyle McCormick ***@***.***>
Enviado: martes, 14 de enero de 2025 16:44
Para: openedx/edx-platform ***@***.***>
Cc: Juan Carlos Iasenza ***@***.***>; Mention ***@***.***>
Asunto: Re: [openedx/edx-platform] style: Explore Courses button doesn't follow the same style conventions of MFE header (PR #35994)
Merged #35994<#35994> into master.
—
Reply to this email directly, view it on GitHub<#35994 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHTWIG34P75NR57PYVTGHQT2KVSI3AVCNFSM6AAAAABTJA5FQWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHEZDSMZZHEZTQNA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
What changed?
I corrected the quotes so that they followed the same MFE style conventions.
Description
Line 42 in
edx-platform/lms/templates/header/navbar-not-authenticated.html
Line 51 in
edx-platform/lms/templates/header/navbar-authenticated.html
And Testing OK
If something needs to be modified, let me know, thank you!!!
Atte
Juan Carlos (Aulasneo)
Developer Checklist
Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review