-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update preview url to direct to mfe #35687
feat: update preview url to direct to mfe #35687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, need to remove the print
statements before approval.
Otherwise, have tested locally and works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some unit tests appear to be breaking but otherwise code looks good
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
This reverts commit 2373dd0.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR changes unit preview URL. Currently, unit previews render in the legacy learners page. As the learning MFE is developed and refiend, the UI between the legacy page and the MFE begins to diverge. This make it difficult for author to accurately determine what their content will look like for learners before it is published. With the PRs change, unit previews will no longer redirect to the legacy page, but the learning MFE. Additionally, this PR updates the content of the unit iframe depending on if it is in a preview or learner view. This change impact Authors. Some follow-up work may be needed to delete config for
preview.host
Supporting information
JIRA Ticket: AU-1067 🔒
Testing instructions
Deadline
None
Other information
This PR is dependent on
frontend-app-learning
PR #1501