feat: add AccountSettingsEnterpriseReadOnlyFieldsStep pipeline step by pwnage101 · Pull Request #2544 · openedx/edx-enterprise

pwnage101 · 2026-03-04T22:39:19Z

Implements the AccountSettingsEnterpriseReadOnlyFieldsStep PipelineStep for the org.openedx.learning.account.settings.read_only_fields.requested.v1 openedx-filter. When a user is linked to an enterprise customer whose SSO IdP has sync_learner_profile_data enabled, the step adds ENTERPRISE_READONLY_ACCOUNT_FIELDS to the readonly_fields set. The name field is only included when a UserSocialAuth record exists for the IdP backend.

ENT-11510

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

Blocked by:

feat: add AccountSettingsReadOnlyFieldsRequested filter openedx-filters#334

Blocks:

feat: replace enterprise_support import with AccountSettingsReadOnlyFieldsRequested filter openedx-platform#38098

codecov · 2026-03-26T16:36:25Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

kiram15 · 2026-03-26T17:44:48Z

enterprise/api/v1/views/enterprise_customer_admin.py

        fn=lambda request, *args, **kwargs: kwargs.get('enterprise_customer_uuid'),
    )
-    def delete_admin(self, request, enterprise_customer_uuid=None, id=None):  # pylint: disable=redefined-builtin,unused-argument
+    def delete_admin(self, request, enterprise_customer_uuid=None, id=None):  # pylint: disable=redefined-builtin


lint error for unnecessary pylint ignore

enterprise/filters/accounts.py

pwnage101

Apologies, but I took a deeper look at the code and found many things I don't like!

enterprise/filters/accounts.py

tests/filters/test_accounts.py

enterprise/filters/accounts.py

Copilot

Pull request overview

Adds an edx-enterprise pipeline step that participates in the org.openedx.learning.account.settings.read_only_fields.requested.v1 openedx-filter to mark certain account settings fields as read-only for learners whose enterprise SSO IdP is configured to sync profile data.

Changes:

Introduce AccountSettingsReadOnlyFieldsStep to add ENTERPRISE_READONLY_ACCOUNT_FIELDS (conditionally including name based on social auth presence).
Add unit tests covering common branches (no enterprise link, no IdP, no TPA, sync disabled, name excluded without social auth).
Add openedx-filters dependency and bump package version/changelog.

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`enterprise/filters/accounts.py`	Implements the new `PipelineStep` that computes enterprise-driven read-only account fields.
`tests/filters/test_accounts.py`	Adds unit tests for the pipeline step’s main decision branches.
`requirements/base.in`	Adds `openedx-filters` as a runtime dependency.
`requirements/test-master.txt`	Pins/records `openedx-filters` in compiled test requirements.
`requirements/test.txt`	Updates compiled dependency provenance comments related to `openedx-filters`.
`requirements/dev.txt`	Updates compiled dev requirements to include `openedx-filters`.
`requirements/doc.txt`	Updates compiled doc requirements to include `openedx-filters`.
`requirements/edx-platform-constraints.txt`	Updates a pinned dependency version during constraints sync.
`enterprise/__init__.py`	Bumps package version to `6.8.4`.
`CHANGELOG.rst`	Adds the `6.8.4` release entry for this feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

enterprise/filters/accounts.py

requirements/edx-platform-constraints.txt

kiram15 · 2026-03-31T04:43:55Z

tests/test_tpa_pipeline.py


                    fake_get_ec.return_value = enterprise_customer
-                    assert handle_enterprise_logistration(backend, self.user) is None
+                    assert handle_enterprise_logistration.__wrapped__(backend, self.user) is None


Had to use .wrapped to bypass the @partial decorator and test the business logic directly

requirements/doc.in

requirements/test.in

requirements/dev.in

requirements/base.in

enterprise/filters/accounts.py

pwnage101 · 2026-03-31T20:34:39Z

requirements/doc.txt

 # by the following command:
 #
-#    make upgrade
+#    pip-compile --output-file=requirements/doc.txt requirements/doc.in


Nit: this will just be immediately un-done---maybe just keep this make upgrade.

pwnage101 · 2026-03-31T20:42:34Z

Just the Nit above and the fundamental question about matching against all vs. just one provider: #2544 (comment)

The rest LGTM!

Copilot

Pull request overview

Copilot reviewed 14 out of 16 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

enterprise/filters/accounts.py

CHANGELOG.rst

enterprise/filters/accounts.py

pwnage101

✅ LGTM!

This was referenced Mar 4, 2026

feat: add AccountSettingsReadOnlyFieldsRequested filter openedx/openedx-filters#334

Merged

feat: replace enterprise_support import with AccountSettingsReadOnlyFieldsRequested filter openedx/openedx-platform#38098

Open

kiram15 force-pushed the pwnage101/ENT-11510 branch 2 times, most recently from 50361c6 to 304a409 Compare March 26, 2026 17:07

kiram15 reviewed Mar 26, 2026

View reviewed changes

kiram15 marked this pull request as ready for review March 26, 2026 22:26

pwnage101 commented Mar 27, 2026

View reviewed changes

enterprise/filters/accounts.py Outdated Show resolved Hide resolved

kiram15 force-pushed the pwnage101/ENT-11510 branch 2 times, most recently from ffa236d to 186d67a Compare March 30, 2026 16:53

pwnage101 commented Mar 30, 2026

View reviewed changes

pwnage101 requested a review from Copilot March 30, 2026 21:42

Copilot started reviewing on behalf of pwnage101 March 30, 2026 21:43 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

enterprise/filters/accounts.py Outdated Show resolved Hide resolved

enterprise/filters/accounts.py Outdated Show resolved Hide resolved

enterprise/filters/accounts.py Outdated Show resolved Hide resolved

requirements/edx-platform-constraints.txt Show resolved Hide resolved

kiram15 force-pushed the pwnage101/ENT-11510 branch 3 times, most recently from 5da2567 to 013bf62 Compare March 31, 2026 04:26

kiram15 reviewed Mar 31, 2026

View reviewed changes

kiram15 force-pushed the pwnage101/ENT-11510 branch from 013bf62 to d2f1767 Compare March 31, 2026 04:59

feat: add AccountSettingsReadOnlyFieldsStep pipeline step

fea50a5

kiram15 force-pushed the pwnage101/ENT-11510 branch from d2f1767 to fea50a5 Compare March 31, 2026 15:46

pwnage101 commented Mar 31, 2026

View reviewed changes

requirements/doc.in Outdated Show resolved Hide resolved

pwnage101 commented Mar 31, 2026

View reviewed changes

requirements/test.in Outdated Show resolved Hide resolved

pwnage101 commented Mar 31, 2026

View reviewed changes

requirements/dev.in Outdated Show resolved Hide resolved

pwnage101 commented Mar 31, 2026

View reviewed changes

requirements/base.in Show resolved Hide resolved

pwnage101 commented Mar 31, 2026

View reviewed changes

enterprise/filters/accounts.py Outdated Show resolved Hide resolved

iloveagent57 assigned pwnage101 Mar 31, 2026

kiram15 force-pushed the pwnage101/ENT-11510 branch from 3919256 to 2e2abb6 Compare March 31, 2026 19:41

pwnage101 commented Mar 31, 2026

View reviewed changes

kiram15 force-pushed the pwnage101/ENT-11510 branch from 2e2abb6 to cb400fb Compare March 31, 2026 21:08

pwnage101 requested a review from Copilot March 31, 2026 23:16

Copilot started reviewing on behalf of pwnage101 March 31, 2026 23:16 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

enterprise/filters/accounts.py Show resolved Hide resolved

enterprise/filters/accounts.py Outdated Show resolved Hide resolved

CHANGELOG.rst Show resolved Hide resolved

pwnage101 commented Apr 1, 2026

View reviewed changes

enterprise/filters/accounts.py Outdated Show resolved Hide resolved

pwnage101 changed the title ~~feat: add AccountSettingsReadOnlyFieldsStep pipeline step~~ feat: add AccountSettingsEnterpriseReadOnlyFieldsStep pipeline step Apr 1, 2026

kiram15 force-pushed the pwnage101/ENT-11510 branch from cb400fb to 109a270 Compare April 1, 2026 16:20

Merge branch 'master' into pwnage101/ENT-11510

797bdc0

kiram15 force-pushed the pwnage101/ENT-11510 branch from 109a270 to 797bdc0 Compare April 1, 2026 16:27

pwnage101 commented Apr 2, 2026

View reviewed changes

kiram15 approved these changes Apr 6, 2026

View reviewed changes

kiram15 merged commit bd0c369 into master Apr 6, 2026
11 checks passed

kiram15 deleted the pwnage101/ENT-11510 branch April 6, 2026 17:43

Conversation

pwnage101 commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Welcome to Codecov 🎉

Uh oh!

kiram15 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pwnage101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kiram15 Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pwnage101 Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

pwnage101 commented Mar 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pwnage101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pwnage101 commented Mar 4, 2026 •

edited

Loading

codecov bot commented Mar 26, 2026 •

edited

Loading