Skip to content

chore: drop Django 4.2 support #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aznszn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: drop Django 4.2 support #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd84eb1
chore: drop Django 4.2 support
aznszn Mar 25, 2026
3ec662e
chore: pin Django to 5.2 and update CI tox env names
aznszn Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
matrix:
os: [ubuntu-latest]
python-version: ['3.12']
toxenv: [quality, docs, django42, django52]
toxenv: [quality, docs, py312-django52]

Comment on lines 16 to 20
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow matrix uses toxenv: ... django52, but tox.ini doesn't define a django52 environment (it defines py312-django52). With TOXENV=django52, tox will fail due to an unknown environment. Align the matrix value with the tox env name (and update the later coverage if that checks matrix.toxenv=='django52' accordingly), or add a matching django52 tox env.

Copilot uses AI. Check for mistakes.
steps:
- uses: actions/checkout@v4
Expand All @@ -34,7 +34,7 @@ jobs:
run: tox

- name: Run Coverage
if: matrix.python-version == '3.12' && matrix.toxenv=='django52'
if: matrix.python-version == '3.12' && matrix.toxenv=='py312-django52'
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ Change Log
Unreleased
**********

* Dropped Django 4.2 support.

[1.15.0] - 2025-04-25
---------------------

Expand Down
2 changes: 1 addition & 1 deletion requirements/base.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Core requirements for using this application

-c constraints.txt
Django>=2.2 # Web application framework
Django>=5.2,<5.3 # Web application framework
python-dateutil # Python Date Utilities
attrs>=17.2.0 # Attributes without boilerplate
sailthru-client==2.2.3
Expand Down
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ def is_requirement(line):
classifiers=[
'Development Status :: 3 - Alpha',
'Framework :: Django',
'Framework :: Django :: 4.2',
'Framework :: Django :: 5.2',
'Intended Audience :: Developers',
Comment on lines 150 to 154
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR drops Django 4.2 support and the package classifiers now only advertise Django 5.2, but install_requires is still loaded from requirements/base.in, which currently allows Django>=2.2. That means pip can install this project alongside unsupported Django versions despite the advertised support. Consider updating the Django requirement (in requirements/base.in and/or via constraints) to enforce the minimum supported Django version for releases that drop 4.2.

Copilot uses AI. Check for mistakes.
'License :: OSI Approved :: GNU Affero General Public License v3 or later (AGPLv3+)',
Expand Down
5 changes: 2 additions & 3 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
[tox]
envlist = py{312}-django{42, 52}, docs, quality
envlist = py{312}-django{52}, docs, quality
Comment on lines 1 to +2
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tox envlist defines a single Django test environment named py312-django52, but the CI workflow matrix uses TOXENV=django52. django52 is not a defined tox environment in this repo (no [testenv:django52]), so tox will error in CI. Align the env naming by either updating envlist/adding a django52 env, or updating CI to run py312-django52.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

@aznszn aznszn Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 3ec662e


[testenv]
deps =
setuptools
django42: Django>=4.2,<4.3
django52: Django>=5.2,<5.3
-r{toxinidir}/requirements/test.txt
commands =
Expand Down Expand Up @@ -35,7 +34,7 @@ setenv =
PYTHONPATH = {toxinidir}/:{toxinidir}/edx_ace
deps =
setuptools
quality: Django>=4.2,<4.3
Django>=5.2,<5.3
-r{toxinidir}/requirements/test.txt
-r{toxinidir}/requirements/quality.txt
allowlist_externals =
Expand Down