chore: cleanup unused scripts, update make manifests #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhinandan-Purkait
force-pushed
the
cleanup_tidy
branch
from
279624d
to
305d48b
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #569 +/- ##
========================================
Coverage 96.37% 96.37%
========================================
Files 1 1
Lines 496 496
========================================
Hits 478 478
Misses 14 14
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sinhaashish
reviewed
Jul 23, 2024
sinhaashish
reviewed
Jul 23, 2024
Abhinandan-Purkait
force-pushed
the
cleanup_tidy
branch
12 times, most recently
from
e9880a8
to
592d6e5
Compare
Abhinandan-Purkait
force-pushed
the
cleanup_tidy
branch
from
592d6e5
to
3a22b81
Compare
niladrih
reviewed
Jul 29, 2024
Signed-off-by: Abhinandan Purkait <[email protected]>
Signed-off-by: Abhinandan Purkait <[email protected]>
Signed-off-by: Abhinandan Purkait <[email protected]>
Signed-off-by: Abhinandan Purkait <[email protected]>
Abhinandan-Purkait
force-pushed
the
cleanup_tidy
branch
from
31b0758
to
2d377db
Compare
tiagolobocastro
approved these changes
Jul 30, 2024
Abhinandan-Purkait
force-pushed
the
cleanup_tidy
branch
from
e493954
to
6fadfaf
Compare
Abhinandan-Purkait
force-pushed
the
cleanup_tidy
branch
3 times, most recently
from
9ffc657
to
3ccd34e
Compare
Signed-off-by: Abhinandan Purkait <[email protected]>
Abhinandan-Purkait
force-pushed
the
cleanup_tidy
branch
from
3ccd34e
to
b908623
Compare
Abhinandan-Purkait
changed the title
Abhinandan-Purkait
added a commit
that referenced
this pull request
Sep 10, 2024
* chore: cleanup unused scripts, update make manifets Signed-off-by: Abhinandan Purkait <[email protected]> * chore: generate operator from helm template Signed-off-by: Abhinandan Purkait <[email protected]> * ci: add manifests and codegen validation in pull request Signed-off-by: Abhinandan Purkait <[email protected]> * chore: add comments on the generate-manifests script Signed-off-by: Abhinandan Purkait <[email protected]> * chore: generate zfs-operator by disabling helm labels Signed-off-by: Abhinandan Purkait <[email protected]> --------- Signed-off-by: Abhinandan Purkait <[email protected]>
Merged
Abhinandan-Purkait
added a commit
that referenced
this pull request
Sep 10, 2024
* ci: enhance pull_request workflow (#557) * ci: enhance pull_request workflow Signed-off-by: Abhinandan Purkait <[email protected]> * chore: use ct via nix-shell, Signed-off-by: Abhinandan Purkait <[email protected]> * chore: add the csi-driver step Signed-off-by: Abhinandan Purkait <[email protected]> * fix: the release regex Signed-off-by: Abhinandan Purkait <[email protected]> * chore: remove test.test binary Signed-off-by: Abhinandan Purkait <[email protected]> * chore: add gitignore entry for .test files Signed-off-by: Abhinandan Purkait <[email protected]> * fix: remove redundant die method Signed-off-by: Abhinandan Purkait <[email protected]> * fix: set analytics to be disabled on ci Signed-off-by: Abhinandan Purkait <[email protected]> * fix: shebang, condition check, script input Signed-off-by: Abhinandan Purkait <[email protected]> * chore: move zfs env setup inside nix Signed-off-by: Abhinandan Purkait <[email protected]> * chore: get IMAGE_TAG from chart Signed-off-by: Abhinandan Purkait <[email protected]> * ci: disable the chart releaser workflow temporarily Signed-off-by: Abhinandan Purkait <[email protected]> * chore: don't use yq for extracting version in Makefile Signed-off-by: Abhinandan Purkait <[email protected]> --------- Signed-off-by: Abhinandan Purkait <[email protected]> * chore: replace CRD with auto-generated copy (#564) Signed-off-by: Niladri Halder <[email protected]> * ci: enhance build.yml workflow Signed-off-by: Abhinandan Purkait <[email protected]> * ci: add branch preparation and release CI changes (#567) Signed-off-by: Abhinandan Purkait <[email protected]> * chore: cleanup unused scripts, update make manifests (#569) * chore: cleanup unused scripts, update make manifets Signed-off-by: Abhinandan Purkait <[email protected]> * chore: generate operator from helm template Signed-off-by: Abhinandan Purkait <[email protected]> * ci: add manifests and codegen validation in pull request Signed-off-by: Abhinandan Purkait <[email protected]> * chore: add comments on the generate-manifests script Signed-off-by: Abhinandan Purkait <[email protected]> * chore: generate zfs-operator by disabling helm labels Signed-off-by: Abhinandan Purkait <[email protected]> --------- Signed-off-by: Abhinandan Purkait <[email protected]> * chore: set version to prerelease Signed-off-by: Abhinandan Purkait <[email protected]> --------- Signed-off-by: Abhinandan Purkait <[email protected]> Signed-off-by: Niladri Halder <[email protected]> Co-authored-by: Niladri Halder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the PR
validate-codegenjobs in the workflows, to catch missed kubegen and manifestsinstallerTypeto helm values to change analytics installer type.