Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localpv): restore size to return as part of snapshotshot create response #480

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

hrudaya21
Copy link
Contributor

@hrudaya21 hrudaya21 commented Oct 4, 2023

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:
#416

What this PR does?:
return extra size info when return CreateSnapshot response

Does this PR require any upgrade changes?:
I think normal flow doesn't change, only affect external repo, like kubevirt depends on it to create PVC success.

If the changes in this PR are manually verified, list down the scenarios covered::
After this fix, the snapshot should have non-zero restore size.

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

Copy link
Member

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hrudaya21 hrudaya21 merged commit 6881540 into openebs:develop Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volumesnapshot restoreSize is not set when returning from createSnapshot response
3 participants