Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZNS Support #24

Closed
wants to merge 1 commit into from
Closed

ZNS Support #24

wants to merge 1 commit into from

Conversation

MaisenbacherD
Copy link

This draft PR addresses the issue openebs/mayastor#1297 and shall encourage discussion.
This should not be merged as is as there is a dependency that needs to be resolved before this can potentially be merged:

@MaisenbacherD MaisenbacherD mentioned this pull request Jan 27, 2023
Closed
@MaisenbacherD
Copy link
Author

Rebased this PR onto develop

@orville-wright
Copy link

orville-wright commented Feb 27, 2024 •
edited
Loading

@MaisenbacherD and @tiagolobocastro
The dependency that the OpenEBS fork of spdk to be at v23.01 has now been met and resolved.

Work can now being to merge this code.

@MaisenbacherD - do you need any additional support from the OpenEBS team to merge your work? I would really like to see ZNS support in Mayastor.

~Dave Brace @ Datacore.com

@MaisenbacherD
Copy link
Author

I addressed the comments of openebs/mayastor#1298 that are applicable to this repository :)

tiagolobocastro
tiagolobocastro approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either you or Dmitry will have to fix conflicts as he's changing the spdk-rs build :)

src/bdev.rs Outdated Show resolved Hide resolved
@MaisenbacherD
feat: Add support for zoned block devices
682994d 
Adding setters and getters for zone related fields of the `spdk_bdev`
struct within the BdevBuilder.

Signed-off-by: Dennis Maisenbacher <[email protected]>
@MaisenbacherD
Copy link
Author

Either you or Dmitry will have to fix conflicts as he's changing the spdk-rs build :)

Just rebased onto develop. If there are changes from Dmitry incoming, I am happy to rebase again :)

@MaisenbacherD
Copy link
Author

Closing this PR draft for the same reason as in openebs/mayastor#1298

Thanks, everyone for the in-depth discussions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaisenbacherD @orville-wright @tiagolobocastro