Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup legacy dashboards #113

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Cleanup legacy dashboards #113

merged 7 commits into from
Jul 5, 2024

Conversation

w3aman
Copy link
Contributor

@w3aman w3aman commented May 9, 2024 •
edited
Loading

Fixes #116

avishnu
avishnu reviewed May 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@avishnu
Copy link
Member

avishnu commented May 17, 2024

Please fix jsonnet lint error.

@w3aman w3aman force-pushed the develop branch 2 times, most recently from bd1edc2 to 982b565 Compare May 21, 2024 04:57
@niladrih
Copy link
Member

It might be useful if this repo tracks the version from the umbrella chart.
So, let's set both appVersion and version to 4.0.0? WDYT @avishnu @tiagolobocastro @Abhinandan-Purkait?

@avishnu
Copy link
Member

avishnu commented May 21, 2024

It might be useful if this repo tracks the version from the umbrella chart. So, let's set both appVersion and version to 4.0.0? WDYT @avishnu @tiagolobocastro @Abhinandan-Purkait?

I think, monitoring should follow its own version. Not every release need to have monitoring changes. Wdyt?

@niladrih
Copy link
Member

Alright, sounds good! That brings monitoring to appVersion 3.0.0 and version 1.0.0. A major bump for the semvers.

@w3aman w3aman force-pushed the develop branch 4 times, most recently from 9fa9ab2 to d6bb829 Compare May 22, 2024 04:38
@w3aman w3aman force-pushed the develop branch 3 times, most recently from 26919b8 to 7a8ea1c Compare May 22, 2024 05:12
niladrih
niladrih approved these changes May 22, 2024
View reviewed changes
README.md Show resolved Hide resolved
Abhinandan-Purkait
Abhinandan-Purkait approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@avishnu @tiagolobocastro @niladrih Now that we are doing a major bump should we change the chart name from openebs-monitoring to monitoring ?

contribute/release.md Show resolved Hide resolved
@niladrih niladrih merged commit ac1fc45 into openebs:develop Jul 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avishnu avishnu avishnu approved these changes

@orville-wright orville-wright orville-wright left review comments

@niladrih niladrih niladrih approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@datacore-vvarakantham datacore-vvarakantham Awaiting requested review from datacore-vvarakantham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE] Removal of dashboards for legacy engines
5 participants
@w3aman @avishnu @niladrih @orville-wright @Abhinandan-Purkait