feat(nvme): On command completion handle zoned nvme errors

Zoned related CommandSpecificStatusCodes's should not take out the nexus. Signed-off-by: Dennis Maisenbacher <[email protected]>
openebs · Jun 7, 2024 · 344c3fb · 344c3fb
1 parent 0e10011
commit 344c3fb
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 3 deletions.
diff --git a/io-engine/src/bdev/nexus/nexus_io.rs b/io-engine/src/bdev/nexus/nexus_io.rs
@@ -29,6 +29,7 @@ use crate::core::{
     CoreError,
     Cores,
     IoCompletionStatus,
+    is_zoned_nvme_error,
     IoStatus,
     IoSubmissionFailure,
     IoType,
@@ -271,9 +272,12 @@ impl<'n> NexusBio<'n> {
             self.ctx_mut().successful += 1;
         } else {
             self.ctx_mut().status = IoStatus::Failed;
-            self.ctx_mut().failed += 1;
 
-            self.completion_error(child, status);
+            // Don't take zoned child out on zoned related nvme errors
+            if !is_zoned_nvme_error(status) {
+                self.ctx_mut().failed += 1;
+                self.completion_error(child, status);
+            }
         }
 
         if self.ctx().in_flight > 0 {

diff --git a/io-engine/src/core/mod.rs b/io-engine/src/core/mod.rs
@@ -86,7 +86,17 @@ pub use snapshot::{
     SnapshotXattrs,
 };
 
-use spdk_rs::libspdk::SPDK_NVME_SC_CAPACITY_EXCEEDED;
+use spdk_rs::libspdk::{
+    SPDK_NVME_SC_CAPACITY_EXCEEDED,
+    SPDK_NVME_SC_ZONED_BOUNDARY_ERROR,
+    SPDK_NVME_SC_ZONE_IS_FULL,
+    SPDK_NVME_SC_ZONE_IS_READ_ONLY,
+    SPDK_NVME_SC_ZONE_IS_OFFLINE,
+    SPDK_NVME_SC_ZONE_INVALID_WRITE,
+    SPDK_NVME_SC_TOO_MANY_ACTIVE_ZONES,
+    SPDK_NVME_SC_TOO_MANY_OPEN_ZONES,
+    SPDK_NVME_SC_INVALID_ZONE_STATE_TRANSITION,
+};
 
 mod bdev;
 mod block_device;
@@ -528,6 +538,24 @@ impl From<NvmeStatus> for IoCompletionStatus {
     }
 }
 
+/// Returns true if the given IoCompletionStatus NvmeError can be matched to a Zoned Namespace Command Specific Status Code
+pub fn is_zoned_nvme_error(status: IoCompletionStatus) -> bool {
+    match status {
+        IoCompletionStatus::NvmeError(NvmeStatus::CmdSpecific(cssc)) => match cssc {
+            SPDK_NVME_SC_ZONED_BOUNDARY_ERROR |
+            SPDK_NVME_SC_ZONE_IS_FULL |
+            SPDK_NVME_SC_ZONE_IS_READ_ONLY |
+            SPDK_NVME_SC_ZONE_IS_OFFLINE |
+            SPDK_NVME_SC_ZONE_INVALID_WRITE |
+            SPDK_NVME_SC_TOO_MANY_ACTIVE_ZONES |
+            SPDK_NVME_SC_TOO_MANY_OPEN_ZONES |
+            SPDK_NVME_SC_INVALID_ZONE_STATE_TRANSITION => true,
+            _ => false,
+        },
+        _ => false,
+    }
+}
+
 // TODO move this elsewhere ASAP
 pub static PAUSING: AtomicUsize = AtomicUsize::new(0);
 pub static PAUSED: AtomicUsize = AtomicUsize::new(0);